Twenty Twenty: Wrong parameter name used in searchform.php

[poena]

In searchform.php, the parameter/argument that is used is named
$args['label'], the correct name for use with get_search_form() is $args['aria_label'].

See ​https://developer.wordpress.org/reference/functions/get_search_form/#parameters

[sabernhardt]

Would this be a good first bug?

In addition to replacing 'label' with 'aria_label', Twenty Twenty's searchform template still needs to accept 'label' as a valid parameter (if used in a child theme).

[vipulc2]

Wrong parameter name used in searchform.php in Twenty Twenty changed $argslabel? to $argsaria_label?

[kishanjasani]

Thanks for Patch @vipulc2. Looks good to me.

[sabernhardt]

editing argument to aria-label in get_search_form() functions for 3 files, and updating searchform.php to give a fallback for child theme templates that might use label

[sabernhardt]

This was a little more complicated than I had thought it might be. In addition to updating the argument in 4 files, 51877.2.patch​ adds a fallback for child theme backward compatibility.

[mukesh27]

Just review 51877.2.patch​ and it working fine.

Marking commit for the action.

Ping @SergeyBiryukov

[davidbaumwald]

In 50933:

Twenty Twenty: Correct label attribute references to aria_label in get_search_form.

In the bundled Twenty Twenty theme, a label argument was passed to get_search_form but used as the aria_label on the form. This change updates the argument name to aria_label and maintains backwards compatibility for usage of the original label argument.

Props poena, sabernhardt, ipulc2, kishanjasani, mukesh27.
Fixes #51877.