Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#51881 closed defect (bug) (fixed)

Incorrect function called in test

Reported by: pbearne's profile pbearne Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description (last modified by pbearne)

the test_strips_html in SanitizeTitleWithDashes.php was calling sanitize_title not sanitize_title_with_dashes

so I swapped to the correct function

Attachments (1)

SanitizeTitleWithDashes.php.patch (621 bytes) - added by pbearne 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.7
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @pbearne
4 years ago

  • Description modified (diff)
  • Summary changed from removed duplicate test to Incorrect function called in test

#3 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49701:

Tests: Test that sanitize_title_with_dashes() strips HTML tags.

sanitize_title() already has the same test in its own file.

Props pbearne.
Fixes #51881.

Note: See TracTickets for help on using tickets.