WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#51881 closed defect (bug) (fixed)

Incorrect function called in test

Reported by: pbearne Owned by: SergeyBiryukov
Priority: normal Milestone: 5.7
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description (last modified by pbearne)

the test_strips_html in SanitizeTitleWithDashes.php was calling sanitize_title not sanitize_title_with_dashes

so I swapped to the correct function

Attachments (1)

SanitizeTitleWithDashes.php.patch​ (621 bytes ) - added by pbearne 6 years ago.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review → 5.7
  • Owner set to SergeyBiryukov
  • Status new → reviewing

#2 @pbearne
6 years ago

  • Description modified (diff)
  • Summary removed duplicate test → Incorrect function called in test

@pbearne
6 years ago

#3 @SergeyBiryukov
6 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 49701:

Tests: Test that sanitize_title_with_dashes() strips HTML tags.

sanitize_title() already has the same test in its own file.

Props pbearne.
Fixes #51881.

Note: See TracTickets for help on using tickets.