Opened 4 years ago
Closed 4 years ago
#51886 closed defect (bug) (fixed)
Dashboard - Activity: Latest comments row actions links on focus
Reported by: | kebbet | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | Administration | Keywords: | has-patch has-screenshots commit dev-reviewed |
Focuses: | ui, accessibility, javascript, css | Cc: |
Description
In 5.5.3 the action links in the comments section of the Activity-widget are shown when tabbing through the Dashboard. In trunk and 5.6 RC1 the link-row-actions are not shown. They are focused (I can see URL's in the browser bottom corner) but they are not visible.
An old similar ticket -> #32612
Attachments (5)
Change History (19)
#3
@
4 years ago
Adding that class in the source code in the browser seems to solve the issue, and the widget works as in 5.5.3. (lo-fi testing :D)
Nice @sabernhardt!
#4
@
4 years ago
- Keywords has-patch added; needs-patch removed
It seems this was caused by [49142]. The dashboard widget does not have the table-view-list
class.
Adding the class in the widget is probably an easier way to fix this than editing the script again.
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
4 years ago
@
4 years ago
Thats in incorrect comparison. The issue is the action-links per comment that is hidden in RC1. (The colored links in this screenshot).
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
4 years ago
#8
@
4 years ago
The patch seems to correct the problem (and I don't notice any unintended side-effects).
@
4 years ago
with patch applied, tabbing through both shows and focus indicates the comment moderation action links
#11
@
4 years ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting to the 5.6 branch after a second committer's review.
I can reproduce the issue as well.