![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 6 years ago
Closed 6 years ago
#51892 closed defect (bug) (fixed)
Fix core_update_footer() for new Updates API
| Reported by: | afragen | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.6 |
| Component: | Upgrade/Install | Version: | 5.6 |
| Severity: | normal | Keywords: | has-patch has-screenshots commit dev-reviewed |
| Cc: | Focuses: |
Description (last modified by )
Fixes a regression in 5.6 with the changes in the new Updates API #meta5511.
The admin footer no longer displays the 'You are using a development version (%1$s). Cool! ... message when using the WP_AUTO_UPDATE_CORE constant set to update to beta or rc when the user is on a development version.
Attachments (6)
Change History (23)
#5
@
6 years ago
- Keywords commit added
- Resolution fixed
- Status closed → reopened
Reopening for backporting to the 5.6 branch after a second committer's review.
#6
@
6 years ago
- Keywords dev-reviewed added; dev-feedback removed
[49708] looks good here, +1 to add to the 5.6 branch.
This ticket was mentioned in Slack in #core by pbiron. View the logs.
6 years ago
#11
@
6 years ago
For the context behind 51892.3.diff see this slack thread.
#12
@
6 years ago
Patch for alpha/beta/RC looks good to me.
For reference, it addresses the issue raised today in this thread in #core-auto-updates Slack channel.
#13
@
6 years ago
To summarize the Slack thread linked above, if get_preferred_from_update_core() gets an empty response from get_core_updates(), it returns an object with 'response' => 'latest' and no other properties, so checking $cur->version without making sure it exists can cause a PHP warning.
Checking $wp_version instead would be more consistent with core_upgrade_preamble(), see [49709] / #51822.
Additionally, $cur->url is unused since [8595] and can be safely removed.
#15
@
6 years ago
- Keywords commit dev-feedback added
- Resolution fixed
- Status closed → reopened
Reopening for backporting to the 5.6 branch after a second committer's review.
Thanks for the patch!
Since this is a regression and an easy fix, I think this is a good candidate for 5.6. Related: #51822.