Application Passwords: Ambiguous error when recording password usage

[dlh]

WP_Application_Passwords::record_application_password_usage() returns "True if the usage was recorded, a WP_Error if an error occurs."

If a password has already been used in the last day, the new usage isn't recorded, and an error is returned. However, the error code given is application_password_not_found, which doesn't seem accurate.

The attached patch would have the method return true when a password's usage has already been recorded for the day on the theory that, at the time, no error occurred.

Alternatively, a WP_Error with a different error code specific to this case could be returned on the theory that the usage was not recorded this time.

[SergeyBiryukov]

Thanks for the patch! Moving to the milestone for visibility.

[TimothyBlynJacobs]

Great catch @dlh! Yeah I think returning true makes sense here. I agree it isn't a 5.6 showstopper, will defer to @SergeyBiryukov on whether we should backport.

[TimothyBlynJacobs]

In 49739:

App Passwords: Return true when rate limiting a password's last used time.

Previously we returned a WP_Error instance saying that the password was not found which is inaccurate.

Props dlh.
Fixes #51922.

[SergeyBiryukov]

[49739] looks good to backport.

[SergeyBiryukov]

In 49740:

App Passwords: Return true when rate limiting a password's last used time.

Previously we returned a WP_Error instance saying that the password was not found which is inaccurate.

Props dlh.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49739] to the 5.6 branch.
Fixes #51922.