WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Last modified 6 months ago

#51926 new defect (bug)

Network Site Search should search more than just wp_blogs.path

Reported by: MadtownLems Owned by:
Priority: normal Milestone: Future Release
Component: Networks and Sites Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses: multisite

Description

From /wp-admin/network/sites.php, searching sites for 'foo' looks to only search the wp_blogs.path column. This was fine up until WordPress let you put sites any any domain.

Now searching for 'foo' would show me sites such as this:
​https://mysite.com/foo
​https://mysite.com/foodsite

but does NOT show me sites such as
​https://foo.com
​https://foo.mysite.com

I believe the search should include the domain for the site as well as the path.

Change History (10)

#2 @peterwilsoncc
4 years ago

  • Milestone Awaiting Review → 6.1

I've linked a ​draft pull request to this ticket.

I'll put this on the WP 6.1 milestone although I think it will need a little more work and some unit tests.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
4 years ago

#4 @audrasjb
4 years ago

  • Keywords needs-unit-tests added
  • Milestone 6.1 → Future Release

Unfortunately, this ticket didn’t get more momentum in 6.1 than in 6.0… sorry about that, but the proposed patch still needs testing, so let's move it to Future Release milestone, at least until it's properly reviewed and tested.

Feel free to move it to 6.2 when it gets the needed unit tests and review :)

This ticket was mentioned in ​Slack in #core-multisite by realloc. ​View the logs.
15 months ago

This ticket was mentioned in ​Slack in #core-multisite by arunas. ​View the logs.
15 months ago

This ticket was mentioned in ​PR #8922 on ​WordPress/wordpress-develop by ​@Soean.
15 months ago #7

  • Keywords has-unit-tests added; needs-unit-tests removed

Update of ​https://github.com/WordPress/wordpress-develop/pull/2719

Trac ticket: https://core.trac.wordpress.org/ticket/51926

#8 @SergeyBiryukov
9 months ago

  • Milestone Future Release → 7.0

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
6 months ago

#10 @audrasjb
6 months ago

  • Milestone 7.0 → Future Release

As per today's 7.0 bug scrub: No activity in 9 months, no ticket owner, and unit tests are failing currently: Let's move it to future release, pending formal review.

Note: See TracTickets for help on using tickets.