WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#51946 closed defect (bug) (fixed)

Twenty Seventeen: Change WhatsApp URL in social links menu

Reported by: carepsules's profile carepsules Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-dev-note
Focuses: Cc:

Description

This is a follow-up to #43999.

I believe that url for whatsapp links are "wa.me/"phnnumber and not "whatsapp.com"

Attachments (3)

51946.patch​ (584 bytes) - added by dkarfa 4 years ago.
51946.1.patch​ (591 bytes) - added by dkarfa 4 years ago.
51946.2.patch​ (564 bytes) - added by sabernhardt 4 years ago.

Download all attachments as: .zip

Change History (8)

@dkarfa
4 years ago

#1 @dkarfa
4 years ago

Hi @carepsules,

Thanks for the reporting this and welcome to WordPress Trac. I have reviewed and create patch for it.

Thank you,
Deb

@dkarfa
4 years ago

#2 @SergeyBiryukov
4 years ago

  • Summary changed from Whatsapp support url to Twenty Seventeen: Change WhatsApp URL in social links menu

@sabernhardt
4 years ago

#3 @sabernhardt
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.9

Related: #50542 (Twenty Twenty)

I made a patch that adds support for the preferred wa.me URL, but it also continues to work for anyone who uses the whatsapp.com domain.

#4 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51617:

Twenty Seventeen: Add support for wa.me links in Social Links menu.

This ensures that wa.me links, currently preferred by WhatsApp, have the same icon as whatsapp.com links.

Follow-up to [48027].

Props sabernhardt, carepsules, dkarfa.
Fixes #51946.

#5 @sabernhardt
3 years ago

  • Keywords has-dev-note added

The ​Bundled themes update note has a section about this.

Note: See TracTickets for help on using tickets.