#51950 closed defect (bug) (fixed)
Twenty Twenty-One: Fix inconsistent HTML comments after closing HTML tags
Reported by: | arcangelini | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.6.1 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | Bundled Theme | Keywords: | has-patch, fixed-major, twenty-twenty-one-1.1 |
Focuses: | coding-standards | Cc: |
Description
The post id number is missing in the code comment of the content loop. Specifically in: twentytwentyone/template-parts/content/content.php:46
</article><!-- #post-${ID} -->
Should be...
</article><!-- #post-<?php the_ID(); ?> -->
Attachments (1)
Change History (9)
#1
@
4 years ago
- Component changed from General to Bundled Theme
- Summary changed from Post ID missing in comments to Twenty Twenty-One: Fix inconsistent HTML comments after closing HTML tags
#2
@
4 years ago
- Keywords has-patch added
Hi @arcangelini and welcome to WordPress Core Trac,
That's a good catch.
51950.diff
fixes this small issue in the following files:
- image.php
- template-parts/content/content-single.php
- template-parts/content/content.php
#4
@
4 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 49761:
Note: See
TracTickets for help on using
tickets.
Hi there, welcome to WordPress Trac! Thanks for the report.
Looking at the other bundled themes, they do indeed all use
<!-- #post-<?php the_ID(); ?> -->
, some of them since [45209] / #46871.Looks like Twenty Twenty-One is not very consistent with this:
<!-- #post-<?php the_ID(); ?> -->
intemplate-parts/content/content-page.php
.<!-- #post-${ID} -->
in other content templates.So I think it makes sense to bring some consistency here.