WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#51958 closed defect (bug) (fixed)

Twenty Twenty-One: Standardize @since tags on "Twenty Twenty-One 1.0"

Reported by: SergeyBiryukov Owned by: desrosj
Milestone: 5.6.1 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch, fixed-major, twenty-twenty-one-1.1
Focuses: docs Cc:

Description

While reviewing the patch on #51919, I've noticed that Twenty Twenty-One uses a 3-digit versioning scheme 1.0.0, while other bundled themes use a 2-digit 1.X.

Per a quick discussion in #core-themes, the consensus was to standardize on 1.0 for consistency.

Version in style.css and Stable tag in readme.txt are already updated in [49763], this is a follow-up ticket for @since tags in PHP templates and JS files.

In addition to the above, @since tags should include the theme name, e.g. "Twenty Twenty-One 1.0", to avoid being mistakenly interpreted as "WordPress 1.0". This was previously corrected for some other bundled themes in [46827].

For future reference, the versioning scheme for bundled themes should be clarified on:

Attachments (1)

51958.patch (38.6 KB) - added by poena 5 months ago.
Replace @since

Download all attachments as: .zip

Change History (6)

@poena
5 months ago

Replace @since

#1 @poena
5 months ago

  • Keywords has-patch added

#2 @desrosj
5 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 49826:

Twenty Twenty-One: Correct @since inline documentation tags.

Previously, 1.0.0 was used for the version. This is inconsistent with the versioning used in the other default themes, which use use X.X and not X.X.X.

This change corrects all 1.0.0 occurrences to 1.0, and adds the additional context of Twenty Twenty-One to avoid confusion with WordPress 1.0.

Props SergeyBiryukov, poena.
Fixes #51958.

#3 @desrosj
5 months ago

  • Focuses docs added
  • Keywords fixed-major added
  • Milestone changed from 5.7 to 5.6.1
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version set to 5.6

Reopening for backport.

#4 @desrosj
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49829:

Twenty Twenty-One: Correct @since inline documentation tags.

Previously, 1.0.0 was used for the version. This is inconsistent with the versioning used in the other default themes, which use use X.X and not X.X.X.

This change corrects all 1.0.0 occurrences to 1.0, and adds the additional context of Twenty Twenty-One to avoid confusion with WordPress 1.0.

Props SergeyBiryukov, poena.
Merges [49826] to the 5.6 branch.
Fixes #51958.

#5 @desrosj
5 months ago

  • Keywords twenty-twenty-one-1.1 added

Adding a custom keyword for querying tickets included in the Twenty Twenty-One version 1.1 release in the future.

Note: See TracTickets for help on using tickets.