WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#51965 closed defect (bug) (wontfix)

About Page: Full stop is added in wrong place

Reported by: mukesh27 Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.6
Component: Help/About Keywords: has-patch close
Focuses: administration, ui-copy Cc:

Description

In /wp-admin/about.ph:243:

__( 'Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide.</a>' ), 

The full-stop should be put outside the </a> mark-up.

__( 'Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide</a>.' ),

Related: #51961

Change History (9)

This ticket was mentioned in PR #797 on WordPress/wordpress-develop by mukeshpanchal27.


4 months ago

In /wp-admin/about.ph:243:

( 'Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide.</a>' ),

The full-stop should be put outside the </a> mark-up.

( 'Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide</a>.' ),

Trac ticket: https://core.trac.wordpress.org/ticket/51965

Trac ticket:

This ticket was mentioned in PR #797 on WordPress/wordpress-develop by mukeshpanchal27.


4 months ago

In /wp-admin/about.ph:243:

( 'Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide.</a>' ),

The full-stop should be put outside the </a> mark-up.

( 'Check out the latest version of the WordPress Field Guide. It highlights developer notes for each change you may want to be aware of. <a href="%s">WordPress 5.6 Field Guide</a>.' ),

Trac ticket: https://core.trac.wordpress.org/ticket/51965

Trac ticket:

#3 @prbot
4 months ago

github-actions[bot] commented on PR #797:

Hi @mukeshpanchal27! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

#4 @SergeyBiryukov
4 months ago

Thanks for the ticket! This was previously reported in #51813.

As noted in comment:8:ticket:51813, "WordPress 5.6 Field Guide." is a complete sentence, so I think the full stop is in the correct place here.

This is consistent with some other strings in core, for example:

  • "Check again" link on WordPress Updates screen:
    <a href="' ... '">' . __( 'Check again.' ) . '</a>'
    
  • "Search for plugins" link on the Plugins screen:
    <a href=" ... '">' . __( 'Search for plugins in the WordPress Plugin Directory.' ) . '</a>'
    

A similar conversation was also on Slack after 5.6 beta 4:

yui 04:21
<a href="%s">Switch to automatic updates for maintenance and security releases only.</a>
is it really meant to have dot before </a>?
helen 04:25
It’s the entire line, so yes.

That said, this appears to be not a hard and fast rule, there are some other arguments and considerations:
https://ux.stackexchange.com/questions/17331/should-a-full-sentence-html-link-include-the-period-in-the-linked-text

Ideally, if any changes should be made, we'd like to be consistent with this in core.

Marking this with the ui-copy focus for a native English speaker to chime in :)

Last edited 4 months ago by SergeyBiryukov (previous) (diff)

#5 @SergeyBiryukov
4 months ago

  • Focuses ui-copy added

This ticket was mentioned in Slack in #core by lukecarbis. View the logs.


4 months ago

#8 @lukecarbis
4 months ago

  • Keywords close added

@mukesh27 Hi! Thanks again for reporting this. We discussed this issue in a [triage session today on Slack](https://wordpress.slack.com/archives/core/p1608613908266900), and decided to close it for now.

Since we believe that it's a style decision, best to stick with existing core conventions.

#9 @lukecarbis
4 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.