Opened 4 years ago
Closed 3 years ago
#51974 closed defect (bug) (wontfix)
Twenty Twenty-One: Exclude build tool configs and Sass files in build
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 5.6 |
Component: | Bundled Theme | Keywords: | reporter-feedback close |
Focuses: | Cc: |
Description
The current build of Twenty Twenty-One contains a few config files for building the theme which are not necessary to run the theme in production and thus should be removed.
Change History (8)
#3
@
4 years ago
Has there been any issues with the sass and config files in Twenty Nineteen?
Because at the time that theme was released, there were concerns that these files would confuse non developer users because they were not documented for example in the theme handbook.
-I would much rather document it than remove it, and have a developer section on the theme support pages about how to use these tools.
A list of config files that Theme Check normally stops:
https://github.com/WordPress/theme-check/blob/master/checks/filenames.php#L26
#4
@
4 years ago
I would much rather document it than remove it, and have a developer section on the theme support pages about how to use these tools.
I very much agree with this. It's our default theme, it should set the example for people on how to build a theme I think...
#6
@
4 years ago
- Milestone changed from 5.6.1 to 5.7
As this ticket is not an urgent change, we agreed with @poena to move it to next major release.
#7
@
4 years ago
- Keywords close added; needs-patch removed
Considering we've recently re-added the sourcemaps #52377, and continue to use the build process that requires these config files, I think we can close this ticket. Unless there are specific files you want to flag, @ocean90?
Can we define which files specifically? These only got through theme check because, as a default theme, theme-check is skipped for it. It would help us make theme check better to know details.