WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 4 weeks ago

#51974 new defect (bug)

Twenty Twenty-One: Exclude build tool configs and Sass files in build

Reported by: ocean90 Owned by:
Milestone: 5.6.1 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: needs-patch reporter-feedback
Focuses: Cc:

Description

The current build of Twenty Twenty-One contains a few config files for building the theme which are not necessary to run the theme in production and thus should be removed.

Change History (4)

#1 @Otto42
6 weeks ago

Can we define which files specifically? These only got through theme check because, as a default theme, theme-check is skipped for it. It would help us make theme check better to know details.

#3 @poena
5 weeks ago

Has there been any issues with the sass and config files in Twenty Nineteen?

Because at the time that theme was released, there were concerns that these files would confuse non developer users because they were not documented for example in the theme handbook.

-I would much rather document it than remove it, and have a developer section on the theme support pages about how to use these tools.

A list of config files that Theme Check normally stops:
https://github.com/WordPress/theme-check/blob/master/checks/filenames.php#L26

Last edited 5 weeks ago by poena (previous) (diff)

#4 @joostdevalk
5 weeks ago

I would much rather document it than remove it, and have a developer section on the theme support pages about how to use these tools.

I very much agree with this. It's our default theme, it should set the example for people on how to build a theme I think...

#5 @desrosj
4 weeks ago

  • Keywords reporter-feedback added
Note: See TracTickets for help on using tickets.