WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 4 months ago

#51974 new defect (bug)

Twenty Twenty-One: Exclude build tool configs and Sass files in build

Reported by: ocean90 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: reporter-feedback close
Focuses: Cc:

Description

The current build of Twenty Twenty-One contains a few config files for building the theme which are not necessary to run the theme in production and thus should be removed.

Change History (7)

#1 @Otto42
6 months ago

Can we define which files specifically? These only got through theme check because, as a default theme, theme-check is skipped for it. It would help us make theme check better to know details.

#3 @poena
6 months ago

Has there been any issues with the sass and config files in Twenty Nineteen?

Because at the time that theme was released, there were concerns that these files would confuse non developer users because they were not documented for example in the theme handbook.

-I would much rather document it than remove it, and have a developer section on the theme support pages about how to use these tools.

A list of config files that Theme Check normally stops:
https://github.com/WordPress/theme-check/blob/master/checks/filenames.php#L26

Last edited 6 months ago by poena (previous) (diff)

#4 @joostdevalk
6 months ago

I would much rather document it than remove it, and have a developer section on the theme support pages about how to use these tools.

I very much agree with this. It's our default theme, it should set the example for people on how to build a theme I think...

#5 @desrosj
6 months ago

  • Keywords reporter-feedback added

#6 @audrasjb
5 months ago

  • Milestone changed from 5.6.1 to 5.7

As this ticket is not an urgent change, we agreed with @poena to move it to next major release.

#7 @ryelle
4 months ago

  • Keywords close added; needs-patch removed

Considering we've recently re-added the sourcemaps #52377, and continue to use the build process that requires these config files, I think we can close this ticket. Unless there are specific files you want to flag, @ocean90?

#8 @hellofromTonya
4 months ago

  • Milestone changed from 5.7 to Awaiting Review

As the ticket is currently marked as a close candidate and 5.7 RC1 is happening in a few hours, removing this ticket from 5.7 to Awaiting Review.

Note: See TracTickets for help on using tickets.