Core update footer displays incorrect message when on current release -- sometimes

[afragen]

When the user is on the current release, but is set to receive nightlies, via the Beta Tester plugin or otherwise, the footer message will be You are using a development version... technically this is incorrect.

In wp-admin/includes/update.php core_update_footer() --
It displays because the $cur->response is development. I propose that the message be changed under these conditions to Your next update will be to a development version...

[pbiron]

This ticket came about from a conversation Andy and I were having last night.

Suppose I'm running 5.6 and have configured core updates to only happen for RCs (either with the Beta Tester plugin or by define( 'WP_AUTO_UPDATE_CORE', 'rc' ). As it stands, for several months the footer will show You are using a development version (5.6). Cool! which is not true (it might as well say The moon is made of green cheese. :-).

Previously, that incorrect message would only show for at most 12 hours (when the next auto-update happens and then the site would be on trunk). But now with the ability to only auto-update to betas and/or RCs it could be showing for much longer...and the string should be corrected.

51976.diff​ looks good to me.

The only suggestion would be to, maybe, use the logic from the Beta Tester plugin to show what the "next development version" will be based on the current settings. That is, Beta Tester (in it's Settings screen shows: version 5.7-RC1, or 5.7, whichever is released first.). Not sure if that's worth the trouble, but something to consider.

[azaozz]

Hmm, not sure 51976.diff is a good idea. The version in the footer is for the currently running code, not what it may be in the future. The settings (for the future updates) are/should be on the Updates screen :)

As it stands, for several months the footer will show You are using a development version (5.6). Cool! which is not true

Right, should be fixed to show what the current version is. Also thinking, after the Updates screen changes, the word "development" may not belong there. A simple: WordPress version 1.2.3 or WordPress version 4.5-beta6 would be simpler and better imho. If it is a dev. version that will be clearly visible from the $wp_version string.

[pbiron]

Yeah, I never really seen the need for the existing wording that mentions that the current version is a dev version...the version number itself does that.

So maybe the only thing that should be different in the footer for dev versions is including the Stay updated link if $cur->response === 'development.

[afragen]

simplified footer

[afragen]

Remind me not to try and change the status again -- anywhere.

[audrasjb]

Hi @afragen, thank you for putting this patch together,

I see a small i18n issue here:

/* translators: s: URL to WordPress Updates screen. */
$stay_updated = sprintf( __( 'Please <a href="%s">stay updated</a>.' ), network_admin_url( 'update-core.php' ) );
$msg          = $is_development_version ? $msg . '&nbsp;' . $stay_updated : $msg;

Indeed, RTL Locales may need to control the order of the displayed message. Using sprintf would allow them to switch the content of the $msg and $stay_updated strings 🌎😎

When the user is on the current release, but is set to receive nightlies, via the Beta Tester plugin or otherwise, the footer message will be You are using a development version... technically this is incorrect.

Simplify the footer message to Version 5.7-alpha-xxx. Please stay updated. or Version 5.6.

Trac ticket: https://core.trac.wordpress.org/ticket/51976

[afragen]

Replying to audrasjb:

Hi @afragen, thank you for putting this patch together,

I see a small i18n issue here:

/* translators: s: URL to WordPress Updates screen. */
$stay_updated = sprintf( __( 'Please <a href="%s">stay updated</a>.' ), network_admin_url( 'update-core.php' ) );
$msg          = $is_development_version ? $msg . '&nbsp;' . $stay_updated : $msg;

Indeed, RTL Locales may need to control the order of the displayed message. Using sprintf would allow them to switch the content of the $msg and $stay_updated strings 🌎😎

Updated in ​https://github.com/WordPress/wordpress-develop/pull/866

[audrasjb]

The PR looks good to me. @SergeyBiryukov any thought on this localization issue?

[audrasjb]

As per todays #core-auto-updates meeting, let's move this one for commit.

[SergeyBiryukov]

Thanks for the patch!

Personally, I like the existing wording which seems to imply that running a development version is "cool" :) I think it adds a bit of personality, so I'm not quite a fan of removing it.

Re-reading comment:2 and looking at the previous changes in [49708] and [49736], I think the only change needed here is to make sure the message is really about the current $wp_version value and not about the API response.

See 51976.3.diff​. This should address the concerns of displaying an inaccurate message and would also be consistent with the same message in core_upgrade_preamble()​ on WordPress Updates screen.

[audrasjb]

Replying to SergeyBiryukov:

Personally, I like the existing wording that implies that running a development version is "cool" :) I think it adds a bit of personality, so I'm not quite a fan of removing it.

Re-reading comment:2 and looking at the previous changes in [49708] and [49736], I think the only change needed here is to make sure the message is really about the current $wp_version value and not about the API response.

This sounds… cool to me 😊

[SergeyBiryukov]

In 50121:

Upgrade/Install: Display correct message about the current version in the admin footer.

Previously, "You are using a development version" message could be displayed if the user has configured core updates to receive Beta or RC versions, but the update has not happened yet.

This brings some consistency with displaying a similar message in core_upgrade_preamble() on WordPress Updates screen.

Follow-up to [49708], [49736].

Props afragen, pbiron, azaozz, audrasjb, SergeyBiryukov.
Fixes #51976.