WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#51978 closed enhancement (fixed)

Add 'development' as accepted vaue for WP_AUTO_UPDATE_CORE

Reported by: knutsp Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: minor Version: 5.6
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description (last modified by dd32)

knutsp
The 'beta' and 'rc' strings was added to WP_AUTO_UPDATE_CORE constant. Why was 'nightly' not added, too?

dd32 2020-12-09 05:04
That’s a good question :slightly_smiling_face: The main reasoning I didn’t think of even adding it was because if you install a nightly, it stays on nightly forever, there’s no need to opt-in through the constant.

Beta/RC is more complicated as it’s running stable, but augmenting it with Beta/RCs.

https://core.trac.wordpress.org/changeset/49245/trunk/src/wp-includes/update.php could be added to also allow for development or branch-development for nightly/branch nightlies.

The whitelist for that parameter on the dotorg side is: [ 'beta', 'rc', 'stable', 'development', 'branch-development' ]

https://wordpress.slack.com/archives/CULBN711P/p1607486676211300

So I propose this to be implemented, at least 'development'. Reasons:

  1. Completeness
  2. Possibility to run a testing site, running latest development version ("nightly builds"), without the Beta Tester plugin.

Attachments (1)

51978.diff (3.5 KB) - added by xkon 3 months ago.

Download all attachments as: .zip

Change History (14)

#1 @dd32
4 months ago

  • Description modified (diff)

This ticket was mentioned in Slack in #core-auto-updates by hellofromtonya. View the logs.


4 months ago

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


4 months ago

#4 @audrasjb
4 months ago

  • Milestone changed from Awaiting Review to 5.7

Moving for 5.7 consideration.

This ticket was mentioned in Slack in #core-auto-updates by audrasjb. View the logs.


3 months ago

#6 @afragen
3 months ago

  • Keywords good-first-bug needs-patch added

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 months ago

@xkon
3 months ago

#8 @xkon
3 months ago

  • Keywords has-patch added; needs-patch removed

51978.diff adds development as an accepted value and adjusts the Site Health test as well.

I believe I didn't miss anything, but if I did feel free to point out and I'll be happy to refresh :).

#9 @audrasjb
3 months ago

  • Keywords commit added

It looks good to me, thank you @xkon!

#10 @audrasjb
3 months ago

  • Keywords good-first-bug removed

#11 @afragen
3 months ago

Were we going to add branch-development too.

#12 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 50082:

Upgrade/Install: Allow WordPress sites to opt-in to development releases.

The WP_AUTO_UPDATE_CORE constant now supports development and branch-development values.

This makes it possible for sites to opt-in to updating to nightly builds without having to install a plugin.

Follow-up to [49245], [49292].

Props xkon, knutsp, afragen, audrasjb, dd32.
Fixes #51978.

This ticket was mentioned in Slack in #core-site-health by knutsp. View the logs.


3 months ago

Note: See TracTickets for help on using tickets.