WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#51980 closed defect (bug) (fixed)

App Passwords: 'Add New Application Password' submit button is hidden on mobile devices in 'User Profile' page

Reported by: vladytimy Owned by: TimothyBlynJacobs
Milestone: 5.6.1 Priority: normal
Severity: normal Version: 5.6
Component: Application Passwords Keywords: has-patch fixed-major
Focuses: css, administration Cc:

Description

51970 fixed the CSS rule that hides paragraphs in the form in Authorize Application screen, but a similar issue remains in User Profile page.

The "Add New Application Password" button is wrapped in a <p>, so the submit button is not visible on mobile.

For a mobile user, the submit button seems to be (incorrectly) the "Update profile" button. As a result, Application Passwords cannot be used on mobile from User Profile page.

Attachments (2)

hidden_app_psw_submit_on_mobile.png (219.3 KB) - added by vladytimy 6 months ago.
51980.diff (355 bytes) - added by mukesh27 6 months ago.
Patch that fix the display issue

Download all attachments as: .zip

Change History (9)

#1 @mukesh27
6 months ago

  • Keywords needs-patch added

Hi there!

I replicated the same issue. Below CSS affected in responsive design.

@media screen and (max-width: 782px){
   .form-wrap > p {
      display: none;
   }
}

@mukesh27
6 months ago

Patch that fix the display issue

#2 follow-up: @mukesh27
6 months ago

  • Keywords has-patch added; needs-patch removed

#3 in reply to: ↑ 2 @vladytimy
6 months ago

Replying to mukesh27:

I confirm the patch works! Thanks!

#4 @johnbillion
6 months ago

  • Milestone changed from Awaiting Review to 5.6.1

#5 @TimothyBlynJacobs
5 months ago

  • Owner set to TimothyBlynJacobs
  • Resolution set to fixed
  • Status changed from assigned to closed

In 49921:

App Passwords: Ensure the Add New button isn't hidden on mobile.

Also removes an unnecessary !important rule introduced in [49772] when fixing a similar issue.

Props vladytimy, mukesh27.
Fixes #51980.
See [49772].

#6 @TimothyBlynJacobs
5 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#7 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49999:

App Passwords: Ensure the Add New button isn't hidden on mobile.

Also removes an unnecessary !important rule introduced in [49772] when fixing a similar issue.

Props vladytimy, mukesh27.
Merges [49921] to the 5.6 branch.
Fixes #51980.

Note: See TracTickets for help on using tickets.