Make WordPress Core

Opened 2 years ago

Last modified 5 months ago

#51990 new defect (bug)

Codemirror does not support JSX by default as mentioned

Reported by: webbdeveloper's profile webbdeveloper Owned by:
Milestone: Awaiting Review Priority: normal
Severity: major Version: 5.5.3
Component: External Libraries Keywords: needs-patch reporter-feedback
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Hi,
I found an issue with the core code.

It is mentioned on this link that the CodeMirror lib will support JSX by default in the editor.
https://make.wordpress.org/core/2017/10/22/code-editing-improvements-in-wordpress-4-9

But when I use JSX mode, I do see an invalid System error in the editor.

Please see this image:

https://user-images.githubusercontent.com/1482075/100721177-eab92a00-33b6-11eb-84c8-a15da679d79d.png

{
    indentUnit: 2,
    tabSize: 2,
    mode: 'jsx'
}

Change History (3)

#1 @sabernhardt
2 years ago

  • Component changed from General to External Libraries

#2 @SergeyBiryukov
2 years ago

  • Description modified (diff)

#3 @desrosj
5 months ago

  • Keywords reporter-feedback added

Hi @webbdeveloper! Welcome to Trac!

I've been trying to reproduce the issue you're describing, but haven't been able to so far.

Can you clarify what you mean by "when I use JSX mode?" Does this mean you are creating your own code editor instance? It looks like there are no warnings thrown when editing a JSX file in the plugin or theme editors, and linting is not enabled.

Core provides csshint, jshint, and htmlhint support. Is it possible jshint is being enabled?

Note: See TracTickets for help on using tickets.