WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#51996 closed defect (bug) (fixed)

Twenty Nineteen: Among the new Patterns, in the block for Services the translatable String 'Gradient' looks odd

Reported by: transl8or Owned by: ryelle
Milestone: 5.6.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: commit, fixed-major, twenty-nineteen-1.9
Focuses: ui Cc:

Description

I was just checking my translations for the theme Twenty Nineteen after the update today with the newest patterns included.

Using a fresh installation of WordPress 5.6 with the theme Twenty Nineteen activated.
When creating a new page or post and opening the Patterns tab the pattern for Services looks like the word "Gradient" is misplaced.

Should there be a gradient colored background instead of a word?
Not sure how this pattern should look like and what was intend by the designers, so I add a screenshot.

All the other patterns work well und look really good in the theme :)

Attachments (2)

Twenty-Nineteen-Pattern-4Services-Gradient.png (13.1 KB) - added by transl8or 6 months ago.
Twenty Nineteen Theme with new Pattern für Services -- is-the-Gradient-word-Position-ok
51996.patch (3.7 KB) - added by mukesh27 6 months ago.
Initial patch.

Download all attachments as: .zip

Change History (11)

@transl8or
6 months ago

Twenty Nineteen Theme with new Pattern für Services -- is-the-Gradient-word-Position-ok

@mukesh27
6 months ago

Initial patch.

#2 @helen
6 months ago

  • Milestone changed from Awaiting Review to 5.6.1

#3 @transl8or
6 months ago

[ I also discovered issues with the patterns in Twenty Sixteen and will research a bit more on it.
But as it is not a Bundled Theme with 5.6 ... where should/could I create a ticket? @ryelle ]

#4 @ryelle
6 months ago

@transl8or You can create tickets for all the Twenty themes here on trac, they're still labelled Bundled Theme.

#5 @ryelle
6 months ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 49793:

Twenty Nineteen: Add images for use in block patterns.

The block patterns were added in #51099, but the images were not included in the commit. This adds the images to the expected folder.

Props transl8or, mukesh27.
Fixes #51996.

#6 @SergeyBiryukov
6 months ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 5.6 branch.

#7 @desrosj
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49828:

Twenty Nineteen: Add images for use in block patterns.

The block patterns were added in #51099, but the images were not included in the commit. This adds the images to the expected folder.

Props transl8or, mukesh27, ryelle.
Merges [49793] to the 5.6 branch.
Fixes #51996.

This ticket was mentioned in Slack in #core-themes by desrosj. View the logs.


6 months ago

#9 @desrosj
6 months ago

  • Keywords twenty-nineteen-1.9 added

Adding a custom keyword for querying tickets included in the Twenty Nineteen version 1.9 release in the future.

Note: See TracTickets for help on using tickets.