#52010 closed enhancement (fixed)
Twenty Twenty-One: Update the link to dark mode information
Reported by: | justinahinon | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.6.1 | Priority: | normal |
Severity: | minor | Version: | 5.6 |
Component: | Bundled Theme | Keywords: | good-first-bug, has-patch, has-screenshots, commit, fixed-major, twenty-twenty-one-1.1 |
Focuses: | Cc: |
Description (last modified by )
In the customizer, in "Colors & Dark Mode", when a dark background color is selected, a notice appears with a link to have more info about the dark mode feature. This link sends to https://wordpress.org/support/article/twenty-twenty-one/. We can be more precise with https://wordpress.org/support/article/twenty-twenty-one/#dark-mode-support.
This link is also present in "Colors & Dark Mode" tab in the customizer.
Attachments (4)
Change History (15)
#3
@
4 years ago
- Summary changed from Update the link to dark mode informations on Twenty Twenty One support page to Twenty Twenty-One: Update the link to dark mode information
#5
@
4 years ago
- Milestone changed from Awaiting Review to 5.6.1
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#7
@
4 years ago
Thanks for the patch!
Just noticed that one instance of the URL here is translatable, but the other one is not. Would be great to make both URLs translatable, for consistency.
Note: See
TracTickets for help on using
tickets.
The fix for this is straightforward. The links should be changed here https://build.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-customize-notice-control.php#L42 and here https://build.trac.wordpress.org/browser/trunk/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-dark-mode.php#L189.