Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#52010 closed enhancement (fixed)

Twenty Twenty-One: Update the link to dark mode information

Reported by: justinahinon's profile justinahinon Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6.1 Priority: normal
Severity: minor Version: 5.6
Component: Bundled Theme Keywords: good-first-bug, has-patch, has-screenshots, commit, fixed-major, twenty-twenty-one-1.1
Focuses: Cc:

Description (last modified by justinahinon)

In the customizer, in "Colors & Dark Mode", when a dark background color is selected, a notice appears with a link to have more info about the dark mode feature. This link sends to https://wordpress.org/support/article/twenty-twenty-one/. We can be more precise with https://wordpress.org/support/article/twenty-twenty-one/#dark-mode-support.

This link is also present in "Colors & Dark Mode" tab in the customizer.

Attachments (4)

adjust_link_for_dark_mode.patch (2.6 KB) - added by engahmeds3ed 3 years ago.
description.jpg (167.0 KB) - added by engahmeds3ed 3 years ago.
Dark mode Description message before/after update
notice.jpg (150.9 KB) - added by engahmeds3ed 3 years ago.
Notice message before/after update
52010.patch (2.6 KB) - added by engahmeds3ed 3 years ago.
make url translatable.

Download all attachments as: .zip

Change History (15)

#1 @justinahinon
3 years ago

  • Description modified (diff)
  • Keywords good-first-bug added

#3 @SergeyBiryukov
3 years ago

  • Summary changed from Update the link to dark mode informations on Twenty Twenty One support page to Twenty Twenty-One: Update the link to dark mode information

#4 @hellofromTonya
3 years ago

  • Keywords has-patch added

#5 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.6.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

@engahmeds3ed
3 years ago

Dark mode Description message before/after update

@engahmeds3ed
3 years ago

Notice message before/after update

#6 @hellofromTonya
3 years ago

  • Keywords has-screenshots added

#7 @SergeyBiryukov
3 years ago

Thanks for the patch!

Just noticed that one instance of the URL here is translatable, but the other one is not. Would be great to make both URLs translatable, for consistency.

@engahmeds3ed
3 years ago

make url translatable.

#8 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49798:

Twenty Twenty-One: Use a more specific link for Dark Mode instructions.

Make both instances of the link translatable, for consistency.

Props engahmeds3ed, justinahinon.
Fixes #52010.

#9 @SergeyBiryukov
3 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 5.6 branch.

#10 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49819:

Twenty Twenty-One: Use a more specific link for Dark Mode instructions.

Make both instances of the link translatable, for consistency.

Props engahmeds3ed, justinahinon.
Merges [49798] to the 5.6 branch.
Fixes #52010.

#11 @desrosj
3 years ago

  • Keywords twenty-twenty-one-1.1 added

Adding a custom keyword for querying tickets included in the Twenty Twenty-One version 1.1 release in the future.

Note: See TracTickets for help on using tickets.