Make WordPress Core

Opened 14 months ago

Last modified 7 weeks ago

#52028 new defect (bug)

Twenty Fifteen: H5 and H6 headings have the same font size

Reported by: poena Owned by:
Milestone: 6.0 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: good-first-bug has-patch needs-refresh
Focuses: css Cc:

Description

This was originally reported by a user via the report button in the theme directory:

there is one 'elements' issue, namely, Header 6.
When using Header 6, it appears to be as the same size with Header 5 (both same size?)

-Confirmed that both H5 and H6 headings have a default font size of 17px.
Headings should be styled to indicate their importance, where a lower heading level has a smaller size.

Because the default paragraph font size is also 17px, a solution would be to increase
the font size of the H5 heading.

Attachments (3)

52028.diff (691 bytes) - added by akabarikalpesh 14 months ago.
I added h5's font size is 18px. let me know if any changes.
52028.1.diff (2.4 KB) - added by afrid1719 12 months ago.
I have increased the font-size for H5 by 1px for all devices having screen size greater than or equal to 740px.
52028.patch (2.3 KB) - added by aezazshekh 8 weeks ago.
I have increased the tag size by 1pixel for all screen sizes. Please let me know if you have any query about the same.

Download all attachments as: .zip

Change History (6)

@akabarikalpesh
14 months ago

I added h5's font size is 18px. let me know if any changes.

#1 @akabarikalpesh
14 months ago

  • Keywords has-patch needs-testing added
  • Version set to 5.6

#2 @hellofromTonya
14 months ago

  • Version changed from 5.6 to 4.1

The styling in the theme was introduced in 4.1 in this commit.

@afrid1719
12 months ago

I have increased the font-size for H5 by 1px for all devices having screen size greater than or equal to 740px.

@aezazshekh
8 weeks ago

I have increased the tag size by 1pixel for all screen sizes. Please let me know if you have any query about the same.

#3 @sabernhardt
7 weeks ago

  • Keywords needs-refresh added; needs-testing removed
  • Milestone changed from Awaiting Review to 6.0

Thanks for the patches!

When editing the font size, at least in this theme, the line-height and margin values should change as well.

The values for 20px and 18px are already in the stylesheet:

	font-size: 20px;
	font-size: 2rem;
	line-height: 1.4;
	margin-top: 2.8em;
	margin-bottom: 1.4em;
	font-size: 18px;
	font-size: 1.8rem;
	line-height: 1.3333;
	margin-top: 2.6667em;
	margin-bottom: 1.3333em;

And this is an option for 16px:

	font-size: 16px;
	font-size: 1.6rem;
	line-height: 1.25;
	margin-top: 3.25em;
	margin-bottom: 1.625em;
Last edited 7 weeks ago by sabernhardt (previous) (diff)
Note: See TracTickets for help on using tickets.