Opened 4 years ago
Closed 4 years ago
#52029 closed defect (bug) (fixed)
Twenty Twenty-One: missing styles for button[type=submit]
Reported by: | slaFFik | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | ui, css | Cc: |
Description
2021 theme has default styles for input[type=submit]
but it does not have those same styles for button[type=submit]
.
So some plugins, that use button
to submit the form on the front-end, are having CSS issues with 2021.
Attachments (3)
Change History (11)
#1
@
4 years ago
- Summary changed from Twenty Twenty-One: to Twenty Twenty-One: missing styles for button[type=submit]
#5
@
4 years ago
The button styles are found here:
https://github.com/WordPress/wordpress-develop/blob/master/src/wp-content/themes/twentytwentyone/assets/sass/05-blocks/button/_style.scss
and
I recommend changing this only after https://core.trac.wordpress.org/ticket/51927 which updates the buttons.
-There will always be themes that are unstyled, so it is safest for plugins to style their own elements.
This ticket was mentioned in Slack in #core-themes by poena. View the logs.
4 years ago
Note: See
TracTickets for help on using
tickets.
It looks like https://github.com/WordPress/wordpress-develop/blob/master/src/wp-content/themes/twentytwentyone/assets/sass/04-elements/forms.scss should be modified to include additional styles for
button[type=submit]
same asinput[type=submit]
.Not sure what to do with:
button[type=clear]
button
without defined type - most likely apply the same asbutton[type=button]
andbutton[type=submit]
.