Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#52044 closed defect (bug) (fixed)

Twenty Twenty-One: Correct version in file-header.scss

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6.1 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: commit, fixed-major, twenty-twenty-one-1.1
Focuses: Cc:


Background: #51919, #51958.

While reviewing the patch on #51919, I've noticed that Twenty Twenty-One uses a 3-digit versioning scheme 1.0.0, while other bundled themes use a 2-digit 1.X.

Per a quick discussion in #core-themes, the consensus was to standardize on 1.0 for consistency.

Version in style.css and Stable tag in readme.txt are already updated in [49763], but I missed the instance in assets/sass/01-settings/file-header.scss, which ends up in style.css after building.

Change History (5)

#1 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49794:

Twenty Twenty-One: Correct version in file-header.scss.

Fixes #52044.

#2 @SergeyBiryukov
3 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 5.6 branch.

#3 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49816:

Twenty Twenty-One: Correct version in file-header.scss.

Props SergeyBiryukov.
Merges [49799] to the 5.6 branch.
Fixes #52044.

#4 @desrosj
3 years ago

  • Version set to 5.6

#5 @desrosj
3 years ago

  • Keywords twenty-twenty-one-1.1 added

Adding a custom keyword for querying tickets included in the Twenty Twenty-One version 1.1 release in the future.

Note: See TracTickets for help on using tickets.