Unused var/global on xmlrpc

[g30rg3x]

Inside the function pingback_ping in the xmlrpc.php file there is a declared global var called "wp_version", but this var is never used inside the function, i think it should be kill like the one in the recently changeset 6250.

[westi]

Not a candidate for 2.3.1

[anonymized_218323]

The global $wp_version exists, but it might not be used in that function. It was probably the intention to use it eventually, but was forgotten over time. So either the variable should be returned by the call or removed.

Did you do any research as to whether it could be used inside the function or should have been?

[g30rg3x]

Replying to santosj:
Yes, i know that the $wp_version exists on a top level (created by the inclusion of the file version.php inside wp-settings.php) but my guesses is (as you say) it was intended to be used for a porpoise.

Yes indeed one of my theory's is that it was added because they want to used inside a User-Agent string (like other functions do) when the XMLRPC response either a success or a failure Pingback, but eventually it was forgotten and left behind.

[westi]

Fixed in [6364] as part of #5418