WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 12 months ago

Last modified 11 months ago

#52128 closed defect (bug) (fixed)

Typo correction of inline documentation in wp-admin/js/editor.js

Reported by: voboghure Owned by: audrasjb
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: docs Cc:

Description

There is a typo in wp-admin/js/editor.js file on line #374
Wrong word: cusror
Correct word: cursor

Attachments (2)

editor.diff (616 bytes) - added by voboghure 12 months ago.
52128.diff (667 bytes) - added by audrasjb 12 months ago.
Typo correction in base.js file doc block

Download all attachments as: .zip

Change History (9)

@voboghure
12 months ago

#2 @mukesh27
12 months ago

  • Keywords commit added
  • Version 5.6 deleted

Hi there!

Thanks for the patch.

I have added a working directory patch for that JS file.

commit keyword added because patch ready to marge.

@audrasjb
12 months ago

Typo correction in base.js file doc block

#3 follow-up: @audrasjb
12 months ago

  • Milestone changed from Awaiting Review to 5.7
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi @voboghure and welcome to WordPress Core Trac,

Thank you for spotting this! By the way, we need diff files to be generated against WordPress development files and not builded versions of WordPress. 52128.diff refreshes your patch against trunk 🙂

#4 @SergeyBiryukov
12 months ago

  • Summary changed from Typo correction of inline documentation to Typo correction of inline documentation in wp-admin/js/editor.js

#5 @SergeyBiryukov
12 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49841:

Docs: Fix typo in getCursorMarkerSpan() DocBlock in js/_enqueues/wp/editor/base.js.

Props voboghure, mukesh27, audrasjb.
Fixes #52128.

#6 in reply to: ↑ 3 @voboghure
12 months ago

Replying to audrasjb:

Hi @voboghure and welcome to WordPress Core Trac,

Thank you for spotting this! By the way, we need diff files to be generated against WordPress development files and not builded versions of WordPress. 52128.diff refreshes your patch against trunk 🙂

Thanks for pointing this out. And thanks for accepting my contribution :)

Note: See TracTickets for help on using tickets.