WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#52128 closed defect (bug) (fixed)

Typo correction of inline documentation in wp-admin/js/editor.js

Reported by: voboghure's profile voboghure Owned by: audrasjb's profile audrasjb
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: docs Cc:

Description

There is a typo in wp-admin/js/editor.js file on line #374
Wrong word: cusror
Correct word: cursor

Attachments (2)

editor.diff​ (616 bytes) - added by voboghure 4 years ago.
52128.diff​ (667 bytes) - added by audrasjb 4 years ago.
Typo correction in base.js file doc block

Download all attachments as: .zip

Change History (9)

@voboghure
4 years ago

#2 @mukesh27
4 years ago

  • Keywords commit added
  • Version 5.6 deleted

Hi there!

Thanks for the patch.

I have added a working directory patch for that JS file.

commit keyword added because patch ready to marge.

@audrasjb
4 years ago

Typo correction in base.js file doc block

#3 follow-up: @audrasjb
4 years ago

  • Milestone changed from Awaiting Review to 5.7
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi @voboghure and welcome to WordPress Core Trac,

Thank you for spotting this! By the way, we need diff files to be generated against WordPress development files and not builded versions of WordPress. 52128.diff refreshes your patch against trunk 🙂

#4 @SergeyBiryukov
4 years ago

  • Summary changed from Typo correction of inline documentation to Typo correction of inline documentation in wp-admin/js/editor.js

#5 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49841:

Docs: Fix typo in getCursorMarkerSpan() DocBlock in js/_enqueues/wp/editor/base.js.

Props voboghure, mukesh27, audrasjb.
Fixes #52128.

#6 in reply to: ↑ 3 @voboghure
4 years ago

Replying to audrasjb:

Hi @voboghure and welcome to WordPress Core Trac,

Thank you for spotting this! By the way, we need diff files to be generated against WordPress development files and not builded versions of WordPress. 52128.diff refreshes your patch against trunk 🙂

Thanks for pointing this out. And thanks for accepting my contribution :)

​hellofromtonya commented on ​PR #829:
4 years ago #7

Trac ticket closed with changeset https://core.trac.wordpress.org/changeset/49841

Note: See TracTickets for help on using tickets.