WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#52159 closed defect (bug) (fixed)

Twenty Nineteen: `block-patterns` tag is missing from style.scss

Reported by: danfarrow Owned by: desrosj
Milestone: 5.6.1 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch, commit, fixed-major, twenty-nineteen-1.9
Focuses: Cc:

Description

Following up from #51099 where the block-patterns tag was added to style.css, it also needs to be added to the source style.scss

Attachments (1)

twentynineteen-style.scss-tag-update.52159.diff (1004 bytes) - added by danfarrow 9 months ago.
Add block-patterns tag to Twenty Nineteen style.scss

Download all attachments as: .zip

Change History (8)

@danfarrow
9 months ago

Add block-patterns tag to Twenty Nineteen style.scss

#1 @danfarrow
9 months ago

  • Keywords has-patch added

Patch uploaded!

#2 @desrosj
9 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.6.1
  • Owner set to desrosj
  • Status changed from new to assigned
  • Version changed from trunk to 5.6

Hi @danfarrow,

Welcome to Trac, and thanks for this report!

Your report is quite timely as we also just noticed this over on #52160! I'll go ahead and fix this.

#3 @desrosj
9 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49872:

Twenty Nineteen: Add the block-patterns tag to the appropriate SASS file.

This prevents the tag from being removed from styles.css when rebuilding the CSS.

Props danfarrow
Fixes #52159.

#4 @desrosj
9 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport.

#5 @desrosj
9 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49874:

Twenty Nineteen: Add the block-patterns tag to the appropriate SASS file.

This prevents the tag from being removed from styles.css when rebuilding the CSS.

Props danfarrow.
Merges [49872] to the 5.6 branch.
Fixes #52159.

#6 @danfarrow
9 months ago

@desrosj wow that was quick, thank you!

@sabernhardt picked up on it in relation to #45925

Last edited 9 months ago by danfarrow (previous) (diff)

#7 @desrosj
9 months ago

  • Keywords twenty-nineteen-1.9 added

Adding a custom keyword for querying tickets included in the Twenty Nineteen version 1.9 release in the future.

Note: See TracTickets for help on using tickets.