wp_get_attachment_metadata() is broken if no first argument is passed in.

[cfinke]

In r49084 (for #50679), wp_get_attachment_metadata() was changed to improve performance, but it had the side effect of eliminating the ability to call it with no arguments and have it default to using the global $post.

It should be possible to keep the performance improvements for all cases where an attachment ID is passed in by only calling get_post() when $attachment_id is 0. I'll upload a patch shortly.

[cfinke]

If no attachment ID is supplied, try to use the global $post's ID.

[hellofromTonya]

Good catch @cfinke for this regression!

Moving this ticket into the next point release.

[mukesh27]

As per doc @param int $attachment_id Attachment post ID. Defaults to global $post. default value for $attachment_id is global $post but in function use default value to 0.

​https://github.com/WordPress/WordPress/blob/master/wp-includes/post.php#L6075

I think we have to change the doc block for that also? like

* @param int $attachment_id Attachment post ID. Default 0.

[dilipbheda]

Improve inline Doc.

[Mista-Flo]

Hi, thanks for your help guys.

I am not sure the last doc update is not confusing.

Because if not attachment_id is passed, it equals to 0 yes, but then it fallbacks to global post with the modified patch, so it should stay like this IMO.

[audrasjb]

patch refreshed against trunk

[audrasjb]

I refreshed the patch and I ran a quick manual test:

// Used outside the loop.
$data = wp_get_attachment_metadata();
var_export( $data );

// Returns false

[audrasjb]

As per today's bug scrub, let's mark this ticket for commit.

[whyisjake]

In 50039:

Media: Ensure that wp_get_attachment_metadata can return values from the global $post, if avaiable.

In [49084] (for #50679), wp_get_attachment_metadata() was changed to improve performance, but it had the side effect of eliminating the ability to call it with no arguments and have it default to using the global $post.

This change restores that ability, while keeping the performance improvements from the original change.

Fixes #52196.

Props cfinke, hellofromTonya, mukesh27, dilipbheda, Mista-Flo, audrasjb, SergeyBiryukov, whyisjake.

[whyisjake]

In 50040:

Media: Ensure that wp_get_attachment_metadata can return values from the global $post, if avaiable.

In [49084] (for #50679), wp_get_attachment_metadata() was changed to improve performance, but it had the side effect of eliminating the ability to call it with no arguments and have it default to using the global $post.

This change restores that ability, while keeping the performance improvements from the original change.

This changeset brings [50039] to the 5.6 branch.

Fixes #52196.
Props cfinke, hellofromTonya, mukesh27, dilipbheda, Mista-Flo, audrasjb, SergeyBiryukov, whyisjake.

[SergeyBiryukov]

In 50051:

Docs: Revert documentation change for wp_get_attachment_metadata().

This more accurately describes the behavior of the function, and is more consistent with the documentation for other post and attachment functions.

Follow-up to [50039].

Props Mista-Flo.
See #52196.

[SergeyBiryukov]

In 50052:

Docs: Revert documentation change for wp_get_attachment_metadata().

This more accurately describes the behavior of the function, and is more consistent with the documentation for other post and attachment functions.

Follow-up to [50039].

Props Mista-Flo.
Merges [50051] to the 5.6 branch.
See #52196.

[SergeyBiryukov]

Follow-up: #52389