WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

Last modified 4 months ago

#52212 closed defect (bug) (fixed)

Twenty Twenty-One: twenty_twenty_one_get_attachment_image_attributes affects the admin panel

Reported by: denisco Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Description

Twenty Twenty-One v1.1

The function twenty_twenty_one_get_attachment_image_attributes affects the attributes of images in the admin panel.

I faced this problem while developing a plugin for comments (I attached a screenshot).

I think we need to add an additional condition to reduce the effect of this function.

Attachments (2)

52212.png (429.1 KB) - added by denisco 6 months ago.
52212.diff (585 bytes) - added by denisco 6 months ago.

Download all attachments as: .zip

Change History (11)

@denisco
6 months ago

@denisco
6 months ago

#1 @denisco
6 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 5.7

#3 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49930:

Twenty Twenty-One: Make sure filtering attachment image attributes only affects front end and not the admin area.

Props denisco.
Fixes #52212.

#5 @SergeyBiryukov
6 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.7 to 5.6.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.6.1 consideration.

#6 @whyisjake
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 50043:

Twenty Twenty-One: Make sure filtering attachment image attributes only affects front end and not the admin area.

This brings the changes from [49930] to the 5.6 branch.

Props denisco, SergeyBiryukov.

Fixes #52212.

#7 @desrosj
5 months ago

  • Milestone changed from 5.6.1 to 5.6.2

Because this is the only change to Twenty Twenty-One since version 1.1 was released, a new version will not ship today in coordination with 5.6.1.

I'm going to revert this for the time being and move to 5.6.2.

If this change were to remain, users that downloaded 5.6.1 to install a new site would have a slightly different version of Twenty Twenty-One than those that received the theme when updating to 5.6, and that could lead to some confusion.

#8 @desrosj
5 months ago

In 50062:

Twenty Twenty-One: Revert [50043] from the 5.6 branch.

Since a new version of Twenty Twenty-One will not be published in coordination with 5.6.1, this will prevent slight differences between the version of the theme that ships with 5.6.1 and the one users received when updating the theme to version 1.1.

See #52212.

#9 @SergeyBiryukov
4 months ago

  • Milestone changed from 5.6.2 to 5.7
Note: See TracTickets for help on using tickets.