Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #52217, comment 30


Ignore:
Timestamp:
10/29/2024 09:53:58 AM (8 months ago)
Author:
justlevine
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #52217, comment 30

    initial v1  
    99- https://github.com/WordPress/wordpress-develop/pull/7675
    1010
    11 handle all the "easy-remediable" Level 0 violations. The remaining ones () IMO only make sense in the context of PHPStan (mostly undiscovered symbols - https://github.com/justlevine/wordpress-develop/blob/e14ac75beac7dd157ac2b9750b5b98d70926a5d4/tests/phpstan/baseline/level-0.php ), but if you see something on that list that you think makes sense to remediate independently of PHPStan getting merged, please lmk or open a PR against `trunk`.
     11handle all the "easy-remediable" Level 0 violations, aka are independently justifiable from just trying to pass the level, and don't require what could be seen as an "unnecessary refactor"
     12
     13The remaining ones IMO really on make sense in the context of passing PHPStan (mostly undiscovered symbols - https://github.com/justlevine/wordpress-develop/blob/e14ac75beac7dd157ac2b9750b5b98d70926a5d4/tests/phpstan/baseline/level-0.php ), but if you see something on that list that you think makes sense to remediate independently of PHPStan getting merged, please lmk or open a PR against `trunk`.
    1214
    1315Moving on to Level 1 ( ref: https://github.com/WordPress/wordpress-develop/blob/2dd671c8cc23a9ab8b002024246594433c78868a/tests/phpstan/baseline/level-1.php )