Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#52230 closed defect (bug) (fixed)

Color scheme CSS in customizer is overridden by defaults

Reported by: ryelle's profile ryelle Owned by: ryelle's profile ryelle
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.5
Component: Customize Keywords: has-patch has-screenshots commit
Focuses: ui, css Cc:


In [48371], the color scheme colors were applied to the customizer, but they seem to be overridden by higher specificity defaults. As written, the styles also need some cleanup (the highlight color shouldn't be used as a text color in most schemes). The Preview button on small screens is missing a top border on hover.

Attachments (4)

customizer-before.png (173.1 KB) - added by ryelle 3 years ago.
customizer.diff (9.3 KB) - added by ryelle 3 years ago.
customizer-after.png (183.7 KB) - added by ryelle 3 years ago.
52230.diff (9.3 KB) - added by ryelle 3 years ago.

Download all attachments as: .zip

Change History (11)

3 years ago

#1 @ryelle
3 years ago

The color scheme tweaks are visible on hover/focus — for example hovering over the panel titles, or the back/close buttons, focusing the media upload button.

I think the patch matches the intent from #50547, styling the borders with the button-color (which is usually the highlight-color, but in the light blue scheme it's a yellow accent), and uses the link color for the text so it stays readable on the white background.

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.7

This ticket was mentioned in Slack in #core by metalandcoffee. View the logs.

3 years ago

#4 @audrasjb
3 years ago

  • Keywords needs-refresh added


I forced the patch to test it. It looks good to me, but we'll have to refresh it against trunk. @ryelle if you still have the branch locally, would you mind updating your patch? Otherwise, I should be able to refresh it manually :)

3 years ago

#5 @ryelle
3 years ago

  • Keywords needs-refresh removed

Thanks for testing, I've refreshed the patch.

#6 @peterwilsoncc
3 years ago

  • Keywords commit added

Tested the Customizer with various schemes and this does what it says on the pack. I reckon it's good to go in.

#7 @ryelle
3 years ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 50386:

Customizer: Bring admin color schemes back into the customizer.

In #50547, the admin color schemes were added to the customizer UI, but at some point specificity changed and the colors were overridden by the defaults. This brings the color schemes back into the customizer, using the button color as a highlight, with the link color for text to keep things readable.

Follow up to [48371].
Props audrasjb, peterwilsoncc.
Fixes #52230.

Note: See TracTickets for help on using tickets.