Remove useless <strong> tags in labels displayed in plugin/theme editor screens

[audrasjb]

In both wp-admin/plugin-editor.php and wp-admin/theme-editor screens, all labels use <strong> tags.

As every single label is emphasized with a <strong> tag, none of them is really emphasized anymore.

I think it would be nice to remove all strong tags, and if we really need bold font for design purposes (but I really doubt it), we should rather use CSS 😃

[audrasjb]

Plugin code editor screen

[audrasjb]

Theme code editor screen

[SergeyBiryukov]

Good catch. At a glance, I agree these labels don't really need the <strong> tags :)

Removes <strong> tags as suggested in #52232. It must be mentioned that the font-weight of the labels "Documentation" and "Select plugin to edit:" remain bold due to their CSS styling.

Trac ticket: https://core.trac.wordpress.org/ticket/52232

[chemiker]

Hi,

I just submitted a pull request that removes the <strong> tags. In case it is desired that the label "Selected file content:" remains bold please let me know. I'll update the pull request and include the necessary CSS styling.

Best

Alex

[mukesh27]

In both wp-admin/plugin-editor.php and wp-admin/theme-editor screens Selected file content: doesn't use <strong> tag. and Documentation: also not use that tag both elements use font-weight: 600; CSS property so @audrasjb do you think that we need to remove that property from CSS also?

@chemiker PR looks good for other elements.

[chemiker]

Remove strong tags.diff - This will remove <strong> tags as in the GitHub pull request. As a result "Select plugin to edit:" will a normal font-weight while the other labels ("Selected file content:" and "Documentation:") remain bold.

[chemiker]

Remove strong tags and remove bold appearance of all labels.diff - This will remove <strong> tags and apply a normal font-weight for all labels.

[chemiker]

Remove strong tags and keep bold appearance of all labels.diff - This will remove <strong> tags and keep a bold font-weight for all labels (like it looks in the current WordPress version).

[chemiker]

I've just provided three .diff files which consider three different options for styling:

• Remove strong tags.diff - This will remove <strong> tags as in the GitHub pull request. As a result "Select plugin to edit:" will have a normal font-weight while the other labels ("Selected file content:" and "Documentation:") remain bold.
• Remove strong tags and remove bold appearance of all labels.diff - This will remove <strong> tags and apply a normal font-weight for all labels.
• Remove strong tags and keep bold appearance of all labels.diff - This will remove <strong> tags and keep a bold font-weight for all labels (like it looks in the current WordPress version).

Sorry for the "double" pull request on GitHub but as far as I understood the .diff files are needed anyway.

[paaljoachim]

We brought up this ticket during a design triage.
Removing the <strong> tag and instead styling with CSS is a better idea.

I have removed the needs design feedback label.

[chemiker]

Replying to paaljoachim:

We brought up this ticket during a design triage.
Removing the <strong> tag and instead styling with CSS is a better idea.

I have removed the needs design feedback label.

Thanks for your feedback. The patch "Remove strong tags and keep bold appearance of all labels.diff" should be considered then.

[audrasjb]

Hi,

Remove strong tags and keep bold appearance of all labels.diff looks good to me as well.

[SergeyBiryukov]

In 49958:

Accessibility: Administration: Remove <strong> tags from labels on plugin/theme editor screens.

If every single label is emphasized with a <strong> tag, none of them is really emphasized anymore.

This removes the tags in favor of CSS styling, for consistency with the other labels on the screen.

Props chemiker, audrasjb, mukesh27, paaljoachim, estelaris, ibdz, SergeyBiryukov.
Fixes #52232.

[prbot]

​chemiker commented on ​PR #856:

Merged with #72ad4e1bcfecab298f0798c0acb2367a754d7f2b