![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#52232 closed defect (bug) (fixed)
Remove useless <strong> tags in labels displayed in plugin/theme editor screens
| Reported by: | audrasjb | Owned by: | sarahricker |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.7 |
| Component: | Administration | Version: | |
| Severity: | normal | Keywords: | good-first-bug has-patch |
| Cc: | Focuses: | ui, accessibility |
Description
In both wp-admin/plugin-editor.php and wp-admin/theme-editor screens, all labels use <strong> tags.
As every single label is emphasized with a <strong> tag, none of them is really emphasized anymore.
I think it would be nice to remove all strong tags, and if we really need bold font for design purposes (but I really doubt it), we should rather use CSS 😃
Attachments (5)
Change History (19)
#1
@
6 years ago
- Keywords good-first-bug added
- Milestone Awaiting Review → 5.7
Good catch. At a glance, I agree these labels don't really need the <strong> tags :)
This ticket was mentioned in PR #856 on WordPress/wordpress-develop by chemiker.
6 years ago
#2
- Keywords has-patch added
Removes <strong> tags as suggested in #52232. It must be mentioned that the font-weight of the labels "Documentation" and "Select plugin to edit:" remain bold due to their CSS styling.
Trac ticket: https://core.trac.wordpress.org/ticket/52232
#3
@
6 years ago
Hi,
I just submitted a pull request that removes the <strong> tags. In case it is desired that the label "Selected file content:" remains bold please let me know. I'll update the pull request and include the necessary CSS styling.
Best
Alex
#4
@
6 years ago
In both wp-admin/plugin-editor.php and wp-admin/theme-editor screens Selected file content: doesn't use <strong> tag. and Documentation: also not use that tag both elements use font-weight: 600; CSS property so @audrasjb do you think that we need to remove that property from CSS also?
@chemiker PR looks good for other elements.
@
6 years ago
Remove strong tags.diff - This will remove <strong> tags as in the GitHub pull request. As a result "Select plugin to edit:" will a normal font-weight while the other labels ("Selected file content:" and "Documentation:") remain bold.
@
6 years ago
Remove strong tags and remove bold appearance of all labels.diff - This will remove <strong> tags and apply a normal font-weight for all labels.
@
6 years ago
Remove strong tags and keep bold appearance of all labels.diff - This will remove <strong> tags and keep a bold font-weight for all labels (like it looks in the current WordPress version).
#5
@
6 years ago
I've just provided three .diff files which consider three different options for styling:
- Remove strong tags.diff - This will remove
<strong>tags as in the GitHub pull request. As a result "Select plugin to edit:" will have a normal font-weight while the other labels ("Selected file content:" and "Documentation:") remain bold. - Remove strong tags and remove bold appearance of all labels.diff - This will remove
<strong>tags and apply a normal font-weight for all labels. - Remove strong tags and keep bold appearance of all labels.diff - This will remove
<strong>tags and keep a bold font-weight for all labels (like it looks in the current WordPress version).
Sorry for the "double" pull request on GitHub but as far as I understood the .diff files are needed anyway.
This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.
6 years ago
This ticket was mentioned in Slack in #design by estelaris. View the logs.
6 years ago
#9
follow-up:
↓ 10
@
6 years ago
- Keywords needs-design-feedback removed
We brought up this ticket during a design triage.
Removing the <strong> tag and instead styling with CSS is a better idea.
I have removed the needs design feedback label.
#10
in reply to: ↑ 9
@
6 years ago
Replying to paaljoachim:
We brought up this ticket during a design triage.
Removing the <strong> tag and instead styling with CSS is a better idea.
I have removed the needs design feedback label.
Thanks for your feedback. The patch "Remove strong tags and keep bold appearance of all labels.diff" should be considered then.
Plugin code editor screen