WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#5224 closed enhancement (wontfix)

No Self Pings in WordPress Core

Reported by: chmac Owned by:
Milestone: Priority: normal
Severity: minor Version: 2.3
Component: General Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

There's a great plugin called No Self Ping which stops WordPress pinging itself. It's less than a dozen lines of code, and it seems like a really obvious feature (almost a bug in WordPress). I've attached a patch to add it to core.

There may be a smarter way to figure out if the post is submitting back to ourself, but I figured this would cover most cases. It might be possible to add a unique string to the ping request so we can detect it and ignore it if it's from our own site, but this seemed simpler.

Attachments (3)

comment.php.diff (683 bytes) - added by chmac 12 years ago.
5224.patch (1.0 KB) - added by Viper007Bond 12 years ago.
Remove self-pings via a filter (literal copy/paste of the plugin)
5224.2.patch (973 bytes) - added by Viper007Bond 12 years ago.
Avoid function name collisions with the plugin

Download all attachments as: .zip

Change History (12)

@chmac
12 years ago

#1 @Viper007Bond
12 years ago

  • Keywords has-patch added; ping self ping no self ping removed
  • Severity changed from normal to minor
  • Version set to 2.3

Not sure how I feel about this. I kinda like the pings, but I guess could always add a plugin to reverse this.

So yeah, I guess the default should no self ping with the option via a plugin to allow it.

@Viper007Bond
12 years ago

Remove self-pings via a filter (literal copy/paste of the plugin)

#2 @Viper007Bond
12 years ago

Your patch would fail for http://remotesite.com/post.php?about=http://www.myblog.com/, plus there's no way to remove the feature.

Attached patch adds in mdawaffe's plugin (literally a copy/paste) as a filter so it can be removed by a plugin.

#3 @Viper007Bond
12 years ago

  • Keywords 2nd-opinion added

#4 @Viper007Bond
12 years ago

Oh, and when making a patch, make sure to create it from the WordPress root. Your patch is missing the relative path (/wp-includes/). ;)

@Viper007Bond
12 years ago

Avoid function name collisions with the plugin

#5 @foolswisdom
12 years ago

-1, I know a lot of people that enjoy the current behavior. It also benefits by being consistent. I don't see a strong argument that the current behavior is "almost a bug".

#6 @Viper007Bond
12 years ago

  • Type changed from defect to enhancement

I agree isn't a bug. Just comes down to which the majority of people prefer.

It's also easy to delete a self ping but it's harder to resend one. Hmm.

I don't know now honestly. heh

#7 @westi
12 years ago

-1

I think this should stay as a plugin.

#8 @zamoose
12 years ago

-1 from me as well.

I rather enjoy seeing the cross-mojination that I have going on in my posts.

#9 @markjaquith
12 years ago

  • Milestone 2.4 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

-1 -- it gives context to the linked post, without you having to say "Update: I wrote more about this HERE"

Note: See TracTickets for help on using tickets.