WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#52293 closed defect (bug) (fixed)

Twenty Twenty-One: fix leftover rtlcss call in build script

Reported by: yoavf Owned by: SergeyBiryukov
Milestone: 5.7 Priority: lowest
Severity: trivial Version: 5.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The build:rtl script for Twenty Twenty-One has style-dark-mode.css param. This is probably a leftover as that file is now in assets/css/ and has its own rtl build script build:dark-rtl.

While rtlcss doesn't output an error, you can see that only style.css is processed when calling npm run build:rtl

> twentytwentyone@1.1.0 build:rtl ~/wordpress-develop/src/wp-content/themes/twentytwentyone
> rtlcss style.css style-rtl.css style-dark-mode.css style-dark-mode-rtl.css

Saving: ~/wordpress-develop/src/wp-> content/themes/twentytwentyone/style-rtl.css

Attachments (1)

52293-twentytwentyone-fix-build-rtl.diff (1.0 KB) - added by yoavf 8 months ago.

Download all attachments as: .zip

Change History (4)

#1 @yoavf
8 months ago

  • Version set to 5.6

#2 @SergeyBiryukov
8 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 5.7
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49960:

Twenty Twenty-One: Remove leftover file from build:rtl task.

The style-dark-mode.css file is now in assets/css/ and has its own build:dark-rtl task.

Props yoavf.
Fixes #52293.

Note: See TracTickets for help on using tickets.