Add site icon to rest index

[spacedmonkey]

Add site icon to list of site metadata return in the index.

[TimothyBlynJacobs]

Should we expose the id of the attachment and then link to it? Or output get_site_icon_url. If the latter, what sizes should we expose?

[palmiak]

@spacedmonkey you mean the /wp-json/ url right? Together with name, description etc.

Personally I would use the default size provided by get_site_icon_url - it's filtrable so it wouldn't be a problem if someone would like to change it.

[spacedmonkey]

Thanks for the patch @palmiak.

Looking at the patch, it seems like we should add some basic unit tests. Maybe a case with and without a site icon set to see what happens. The tests should be added ​here.

[lephleg]

Hello @palmiak, is there a PR for this in order to add the unit tests?

https://core.trac.wordpress.org/ticket/52321

[palmiak]

I added a test to check if key exists and one more, after setting the image, is the image name correct.

[spacedmonkey]

@TimothyBlynJacobs I feel like we can get this into WP 5.8. It is a simple change.

[TimothyBlynJacobs]

Feature freeze for 5.8 has already ​passed. Feel free to milestone for 5.9 though.