WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 5 weeks ago

#52327 closed defect (bug) (fixed)

Requested updates to the PHP Update Alert

Reported by: chanthaboune Owned by: audrasjb
Milestone: 5.6.1 Priority: high
Severity: normal Version:
Component: Site Health Keywords: has-patch dev-reviewed commit
Focuses: Cc:

Description

I'd like to request a few updates to strings that we display in the PHP Updates Alert. I want to make sure we're being factual in our recommendations to update PHP versions, and also to do our best not to overpromise.

  • Can we replace "PHP Update Required" with "PHP Update Recommended"?
  • Can we clearly display which version of PHP you're on, and/or link to site health?
  • Since lots of hosts patch older versions of PHP, it's generally secure. And we should be careful about overpromised performance depending on which versions you're moving between. Maybe replace "Newer versions of PHP are both faster and more secure, so updating will have a positive effect on your site's performance." with "Newer versions of PHP are created with increased performance in mind, so you may see a positive effect on your site's performance." ...or similar?
  • Can we add the version number in the notice, same for the core WP updates notices in the footer and on the updates page? It should tell you what version you're currently on, as well as what's available.

I think this one belongs in meta trac, but leaving here in case. :)

Attachments (4)

Capture d’écran 2021-01-20 à 20.01.04.png (265.4 KB) - added by audrasjb 6 weeks ago.
52327.diff
52327.diff (3.0 KB) - added by audrasjb 6 weeks ago.
52327.1.diff (3.2 KB) - added by audrasjb 6 weeks ago.
Patch refreshed to take into account comments from @clorith
52327.2.diff (886 bytes) - added by SergeyBiryukov 5 weeks ago.

Download all attachments as: .zip

Change History (21)

#2 in reply to: ↑ 1 @chanthaboune
6 weeks ago

Replying to SergeyBiryukov:

Related: #46326, #47651, #48390. #48716.

Thank you for the cross references! I also chatted with @clorith, who is interested in double checking the alerts we give re: plugins and themes and their PHP (if I understood correctly).

#3 @audrasjb
6 weeks ago

Hi @chanthaboune, welcome to WordPress Core Trac and thank you for opening your first ticket! 😂

Joke apart, I'm currently working on the patch. I agree with the feedback, we can indeed clarify a bit the dashboard widget :)

@audrasjb
6 weeks ago

#4 @audrasjb
6 weeks ago

  • Milestone changed from 5.7 to 5.6.1
  • Owner set to audrasjb
  • Status changed from new to accepted

Milestoning this for 5.6.1, as discussed by the minor release squad.

This ticket was mentioned in Slack in #hosting-community by javier. View the logs.


6 weeks ago

#6 follow-up: @Clorith
6 weeks ago

Thanks for the patch @audrasjb!

I've got some quick feedback here on the copy.

The firsts string now reads

PHP is the programming language we use to build and maintain WordPress.

This part of the text should ideally not be changed, as the use of we is ambiguous, and was intentionally not used for that reason (I see the dashboard widget somehow snuck it in though, so changing that to also read languages used to build in both places seems reasonable).

The first message inside the dashboard widget is patched to read

Your site is running an outdated version of PHP (%s), which requires an update.

This should perhaps also be more aligned with recommendation over required if that's the desired outcome here, for example:

Your site is running an outdated version of PHP (%s), and should be updated.

I'm not entirely sure if we should remove the conditional message separating between secure and outdated, we are doing a bears service (is that an English term? I'm not sure), by tiptoeing around releases that no longer receive security updates. Some hosts may patch them internally, but for every well-services host, there's a dozen ones that do not have routines for that, and presuming everyone does their own patching does not help the end user here I feel.

Erring on the side of "some hosts may not be insecure, even if the PHP versions they offer are no longer receiving security updates, but many may be" still feels right to me here.

@audrasjb
6 weeks ago

Patch refreshed to take into account comments from @clorith

#7 @audrasjb
6 weeks ago

  • Keywords has-patch dev-reviewed added

Thanks @Clorith for the review. Those are relevant comments, and 52327.1.diff addresses them.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 weeks ago

#9 @whyisjake
5 weeks ago

  • Keywords commit added

Changes look good, let's get this merged.

#10 @whyisjake
5 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 50041:

Site Health: Update php update strings to not overpromise performance.

Fixes #52327.

Props chanthaboune, SergeyBiryukov, audrasjb, Clorith, whyisjake.

#11 @whyisjake
5 weeks ago

In 50042:

Site Health: Update php update strings to not overpromise performance.

This commit brings the changes from [40041] to the 5.6 branch.

Fixes #52327.

Props chanthaboune, SergeyBiryukov, audrasjb, Clorith, whyisjake.

#12 in reply to: ↑ 6 @SergeyBiryukov
5 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to Clorith:

The first message inside the dashboard widget is patched to read

Your site is running an outdated version of PHP (%s), which requires an update.

This should perhaps also be more aligned with recommendation over required if that's the desired outcome here, for example:

Your site is running an outdated version of PHP (%s), and should be updated.

This new wording seems ambiguous, to me it reads as "Your site ... should be updated", and not the PHP version.

Could we replace "and should be updated" with "which should be updated"? See 52327.2.diff.

#13 @audrasjb
5 weeks ago

  • Keywords commit removed

@SergeyBiryukov the wording change in 52327.2.diff looks good to me. Indeed, it's more clear that PHP needs to be updated, not the website.

#14 @audrasjb
5 weeks ago

  • Keywords commit added

#15 @whyisjake
5 weeks ago

In 50058:

Site Health: Update the language around how PHP should be updated.

Follow-up to [50042].

Props SergeyBiryukov.

See #52327.

#16 @whyisjake
5 weeks ago

In 50059:

Site Health: Update the language around how PHP should be updated.

Follow-up to [50042].

This is a backport of [50058] to the 5.6 branch.

Props SergeyBiryukov.

See #52327.

#17 @whyisjake
5 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed with [50058].

Note: See TracTickets for help on using tickets.