WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#52328 closed defect (bug) (fixed)

Twenty Twenty-One: Add missing HTML comment for Header tag

Reported by: mukesh27's profile mukesh27 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: good-first-bug has-patch
Focuses: coding-standards Cc:

Description

Add missing HTML comment for below files.

​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwentyone/template-parts/content/content-single.php#L19
​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwentyone/template-parts/content/content-page.php#L20
​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwentyone/template-parts/content/content-page.php#L24

Change History (5)

#1 @mukesh27
4 years ago

If you're doing first time contribution then check these links in order to create a valid patch in trac.

​https://make.wordpress.org/core/handbook/tutorials/working-with-patches/
​https://make.wordpress.org/core/handbook/best-practices/writing-patches/

If you're familiar with code and git, you can use the wordpress-develop Github repository to easily contribute to WordPress: ​https://make.wordpress.org/core/handbook/contribute/git/

This ticket was mentioned in ​PR #884 on ​WordPress/wordpress-develop by ​speedyprem.
4 years ago #2

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/52328

#3 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.7

#4 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49993:

Twenty Twenty-One: Add missing HTML comments for </header> tag.

This brings some consistency to closing </header> tags in theme templates and ensures they all have an associated HTML comment.

Props freewebmentor, mukesh27.
Fixes #52328.

Note: See TracTickets for help on using tickets.