WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#52341 closed task (blessed) (fixed)

Upgrade old branches to run on NodeJS LTS (currently 14.x)

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 5.7 Priority: high
Severity: normal Version: 3.7
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

The WordPress project's current support policy is that only the most recent major version should be considered supported. Currently, this means that 5.6.x is the only maintained branch. However, security fixes are backported as a courtesy and in an effort to promote a more secure web all the way back to the 3.7 branch.

This ticket is not meant to discuss this policy, or any changes to this policy.

In #47767, a simplified local environment based on Docker was introduced to make it easier for a local development environment to be spun up. The intention was to backport this to all supported branches.

#48301 was opened to tackle this, and the local environment has been backported to all branches >= 4.6. However, it cannot be backported further because the devDependencies required for the functionality are not supported in older versions of NodeJS (the 4.5 branch currently uses v4.7.2, and the 3.7 branch currently uses v0.10.48).

In early December of last year (2020), the ​WordPress organization's tests stopped running on TravisCI due to restructuring of their pricing model. This means that our pre-existing test setup has not run since.

The decision was made to after experimenting within #50401 to move all test suites to GitHub Actions using workflows that run tests using the local Docker environment.

Some discussions on #51603 revealed some historical context that there were previous intentions to bring all supported branches in sync with the version of NodeJS being used. However, this never happened. Since this is now a blocker for resuming automated testing in old branches, let's fix it now.

Some notes:

  • The build server will now be able to run a single version of NodeJS for all supported versions. After each commit updating NodeJS in each branch, someone from the systems team will need to ensure each branch successfully changes versions.
  • All minified files, and some unminified files will be affected. This includes JS, CSS, and images.
  • Branches 5.0 and newer have a package-lock.json file, 4.4-4.9 have a npm-shrinkwrap.json file, and 4.3 and lower had no shrinkwrap or lock file.
  • NPM scripts relevant to each branch should also be backported when possible for consistent tooling across branches. But only if it does not require significant additions and changes.

Change History (84)

This ticket was mentioned in ​PR #897 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #1

  • Keywords has-patch added

This updates the 4.6 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/517.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #906 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #2

This updates the 3.8 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

Additionally, NPM scripts have been backported for consistent build/watch related tasks across all branches. Backports for this include:

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/525.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #905 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #3

This updates the 3.9 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

Additionally, NPM scripts have been backported for consistent build/watch related tasks across all branches. Backports for this include:

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/524.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #904 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #4

This updates the 4.0 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

Additionally, NPM scripts have been backported for consistent build/watch related tasks across all branches. Backports for this include:

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/523.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #903 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #5

This updates the 4.1 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

Additionally, NPM scripts have been backported for consistent build/watch related tasks across all branches. Backports for this include:

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/522.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #902 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #6

This updates the 4.2 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

Additionally, NPM scripts have been backported for consistent build/watch related tasks across all branches. Backports for this include:

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/521.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #901 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #7

This updates the 4.3 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

Additionally, NPM scripts have been backported for consistent build/watch related tasks across all branches. Backports for this include:

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/520.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #900 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #8

This updates the 4.4 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/519.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #899 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #9

This updates the 4.5 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### Removed packages
Dependencies that were not addressed in newer branches and updated in the backports above have also been updated to their latest versions.

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/517.

### Local Docker Environment
The local Docker environment is also backported in this branch, though it should be committed separately from the other NodeJS updates.
Merges [45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49335,49358,49360,49362] to the 4.5 branch.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #895 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #10

This updates the 4.7 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Tooling
This backports https://core.trac.wordpress.org/changeset/39361 to prevent accidentally including patch related files.

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/516.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #894 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #11

This updates the 4.8 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/515.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #893 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #12

This updates the 4.9 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/514.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #892 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #13

This updates the 5.0 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/513.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #891 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #14

This updates the 5.1 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/512.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #890 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #15

This updates the 5.2 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/511.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #889 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #16

This updates the 5.3 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/510.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #886 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #17

This updates the 5.4 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/509.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

This ticket was mentioned in ​PR #885 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #18

  • Keywords has-unit-tests added

This updates the 5.5 branch to run on the latest LTS version of NodeJS (currently 14.x).

### Update devDependencies
All development dependencies have been updated to versions that support 14.x. The following commits are included as backports:

### browserslist updates
This PR also includes changes suggested in Core-52331 to ensure consistent vendor prefixes within the branch as time progresses.

### Generated files
All generated JS/CSS files have been updated.

### Simulating build server output
A companion PR has been opened to simulate the output of the build server after the changes in this PR: ​https://github.com/WordPress/WordPress/pull/508.

Trac ticket: https://core.trac.wordpress.org/ticket/52341

#19 @desrosj
4 years ago

Above all the PRs are attached. Notes about implementation across all branches:

  • In branches where an npm-shrinkwrap.json file was present, that file remains and was updated using npm shrinkwrap --no-optional. Where no shrinkwrap/lock file was present, I added a package-lock.json file. When a package-lock.json file was present, it was updated. Ideally, we should use the same file type in all older branches (thinking shrinkwrap).
  • Each PR has an accompanying PR on the WordPress/WordPress build repo mirror. They are linked in each respective PR, or you can find them all with ​this link.
  • I did not convert tools. For example, branches that used grunt-cssjanus remained on grunt-cssjanus and were not updated to use grunt-rtlcss.
  • In each branch, the JS, CSS, and images were updated accordingly. This will result in a lot of files being updated in the next update released for each branch. However, while I was working on this, it occurred to me that the images don't really need to be re-minified. While shrinking their size would be nice, we don't have to do that at the same time as the CSS or JS, or we could skip it all together for the really old branches.
  • For the most part, the QUnit tests for almost all branches pass with the same number of assertions as the ​last successful TravisCI build for each branch. One or two branches were displaying some CORS warnings, and I believe there was one branch that had less assertions than the last successful build. Will investigate this further.
  • I included the local Docker environment in all branches < 4.6 for the purposes of easier testing. The 3.7-4.0ish branches are having some issues running the install command, but a manual install will successfully set up a site.
  • Each branch can be tested by checking out, changing the LOCAL_DIR to build in the .env file and running rm -rf node_modules && npm install && npm run env:start && npm run build && npm run env:install. That will give you a working install in the local Docker environment accessible at localhost:8889.
  • Several branches had outdated browser prefixes present in their CSS files. Those have been removed from running npm run grunt precommit:css and compiled into the respective PR on the build repository. However, all changes need to be inspected and confirmed as non-problematic.

#20 @desrosj
4 years ago

Few more notes:

  • I also did not backport tools that were not present in the branch. For example, JS documentation linting added in 5.5 was not backported, coding standards tooling that was added in 5.1 was not backported, etc.
  • For the .nvmrc file, I currently have 14 as the value. This would keep the user within the last tested LTS, while still running the latest release in that series. lts/* was present in many newer branches, but the best approach for this is not clear to me. Using 14 would require a commit to each branch moving forward when new LTS versions are released. But it would also prevent branches from suddenly failing.
  • I updated the engines values in the package.json file to be ranges, using >=. With the deprecation of engines-strict, these values are merely suggestions, so this seems OK, but open to learning best practices here.
Last edited 4 years ago by desrosj (previous) (diff)

#21 @desrosj
4 years ago

One last thought about maintaining this going forward. Once a quarter or so, all of the package updates in trunk should be collected by a component maintainer and evaluated for backporting. It doesn’t have to happen every quarter, but definitely will need to happen every time a new LTS version is released.

#22 @netweb
4 years ago

This ticket was mentioned in PR #885 on WordPress/wordpress-develop by desrosj.

Copy & Paste Review of PR ​https://github.com/WordPress/wordpress-develop/pull/885 for the WordPress 5.5 branch

  • ✅ npm, package.json, and package-lock.json changes are ok
  • ✅ CSS changes via autoprefixer are ok
  • ⚠️ There's various image changes here in this PR
    • A few images removed, loading.gif is my biggest concern
    • A few images are added

In the list of core commits cited in this PR, none of these commits relate to any images, so I'm unsure why and where these changes to the images comes from in this PR.

So, apart from the image changes in this PR it looks good and I would have approved the PR if it wasn't for these unknown image changes.

Replying to desrosj:

  • In each branch, the JS, CSS, and images were updated accordingly. This will result in a lot of files being updated in the next update released for each branch. However, while I was working on this, it occurred to me that the images don't really need to be re-minified. While shrinking their size would be nice, we don't have to do that at the same time as the CSS or JS, or we could skip it all together for the really old branches.

Seeing the image notes here from above, the above speaks to re-minifying images, not changing images by both removing images and adding images, so I'm still unsure why these image changes are in this PR.

#23 @netweb
4 years ago

It's looking like a common theme, happy to approve all the npm, package.json, package-lock.json, autoprefixer changes for the following PRs as I see the same/similar changes between each of the following PRs

Note: As per the 5.5 review above, I see the same image additions and removals in each of these PRs

WordPress 5.4

This ticket was mentioned in PR #886 on WordPress/wordpress-develop by desrosj.
PR ​https://github.com/WordPress/wordpress-develop/pull/886 for the WordPress 5.4 branch

  • ✅ npm, package.json, and package-lock.json changes are ok
  • ✅ CSS changes via autoprefixer are ok
  • ⚠️ There's various image additions and removals

WordPress 5.3

This ticket was mentioned in PR #889 on WordPress/wordpress-develop by desrosj.
PR ​https://github.com/WordPress/wordpress-develop/pull/889 for the WordPress 5.4 branch

  • ✅ npm, package.json, and package-lock.json changes are ok
  • ✅ CSS changes via autoprefixer are ok
  • ⚠️ There's various image additions and removals

WordPress 5.2

This ticket was mentioned in PR #890 on WordPress/wordpress-develop by desrosj.
PR ​https://github.com/WordPress/wordpress-develop/pull/890 for the WordPress 5.4 branch

  • ✅ npm, package.json, and package-lock.json changes are ok
  • ✅ CSS changes via autoprefixer are ok
  • ✅ Gruntfile changes are ok
  • ⚠️ There's various image additions and removals

WordPress 5.1

This ticket was mentioned in PR #891 on WordPress/wordpress-develop by desrosj.
PR ​https://github.com/WordPress/wordpress-develop/pull/891 for the WordPress 5.4 branch

  • ✅ npm, package.json, and package-lock.json changes are ok
  • ✅ CSS changes via autoprefixer are ok
  • ✅ Gruntfile changes are ok
  • ⚠️ There's various image additions and removals

WordPress 5.0

This ticket was mentioned in PR #892 on WordPress/wordpress-develop by desrosj.
PR ​https://github.com/WordPress/wordpress-develop/pull/892 for the WordPress 5.4 branch

  • ✅ npm, package.json, and package-lock.json changes are ok
  • ✅ CSS changes via autoprefixer are ok
  • ✅ Gruntfile changes are ok
  • ⚠️ There's various image additions and removals

Note: If the image changes are indeed expected and I've missed something as to why they are there, consider this comment for the 5.x branches above as +1 for commit

I'll come back and look at the 4.x & 3.x branches in a little while.

This ticket was mentioned in ​Slack in #core by francina. ​View the logs.
4 years ago

#25 @francina
4 years ago

  • Owner set to desrosj
  • Status changed from new to assigned

#26 @desrosj
4 years ago

  • Keywords has-unit-tests removed

For the images, I did run precommit:images and committed the changes in ​https://github.com/WordPress/wordpress-develop/pull/885/commits/fab68cdac95ef3c9f07f2c93e3516d9a4d514d9a for the 5.5 branch.

It looks like there is one image being "removed", but it's still technically there. The imagemin script just reduced it enough to be considered a 100% change in size.

I was talking the ticket over with @dd32 yesterday on Slack, and we were discussing the number of files being changed in each branch. We should try to limit this number as best we can. For the images, it's important that the grunt precommit:images script works, but including the images changed for each branch is not necessary for this process. I'm going to remove the image changes from each branch.

Another item to note that I briefly touched on in the PR descriptions but is worth elaborating on. Some dependencies were updated to versions that work on NodeJS 14.x, but not to their latest versions. This was most common for Webpack aand related packages. I did not update Webpack tooling across branches. The version of Webpack used in a branch remained the same. Because related packages usually drop support for older versions of Webpack in major versions, this results in a handful of those dependencies being up to date within a major version range, but not 100% up to date. This only affects WP branches >= 5.0.

​desrosj commented on ​PR #885:
4 years ago #27

For the images, I did run precommit:images and committed the changes in ​https://github.com/WordPress/wordpress-develop/pull/885/commits/fab68cdac95ef3c9f07f2c93e3516d9a4d514d9a for the 5.5 branch.

It looks like there is one image being "removed", but it's still technically there. The imagemin script just reduced it enough to be considered a 100% change in size. Thinking this over more, though, the image changes are not required. The script should be confirmed as working, but we can exclude the resulting changes from this PR in order to limit the number of files changed in each branch.

#28 follow-up: @desrosj
4 years ago

I've removed all image changes from every branch. This cut down the number of files changed by between 30-70, depending on the branch.

Additionally, I discovered that some files in the 5.x branches were changed unnecessarily. Somehow, the versions of nested dependencies were updated in the lock file and this caused Gutenberg dependencies to change. I've fixed this in those branches, and updated the associated build PR.

#29 in reply to: ↑ 28 @netweb
4 years ago

  • Keywords commit added

Replying to desrosj:






comment







765472388

}}}

​desrosj commented on ​PR #885:





For the images, I did run precommit:images and committed the changes in ​https://github.com/WordPress/wordpress-develop/pull/885/commits/fab68cdac95ef3c9f07f2c93e3516d9a4d514d9a for the 5.5 branch.





It looks like there is one image being "removed", but it's still technically there. The imagemin script just reduced it enough to be considered a 100% change in size. Thinking this over more, though, the image changes are not required. The script should be confirmed as working, but we can exclude the resulting changes from this PR in order to limit the number of files changed in each branch.









Ah, that's what I missed, I didn't look close enough 👍🏼





Replying to desrosj:







I've removed all image changes from every branch. This cut down the number of files changed by between 30-70, depending on the branch.







Yes, this looks good, this will help the autoupdate process and keep those distribution packages 

a little smaller, and in particular less files 👍🏼





Replying to desrosj:







Additionally, I discovered that some files in the 5.x branches were changed unnecessarily. Somehow, the versions of nested dependencies were updated in the lock file and this caused Gutenberg dependencies to change. I've fixed this in those branches, and updated the associated build PR.







Again, looks good 👍🏼





Aside, in a future release we could update some of these additional webpack and Gutenberg dependencies and ship these minified images, CSS changes, JS changes in future releases, for example ship CSS change in 5.0.13, JS changes in 5.0.14, minified images in 5.0.15 to keep the number of changes files per release to a minimum, it's a little painful for sure, but in the end we would have a consistent set of packages, and it's not like we haven't been releasing new releases of the 3.7.x branch for 7 years 😉







Overall looks good to me for the 5.0-5.5 branches, I've still not looked at the older branches, but the concept should be the same I expect, will try and take a look closer later today.





Happy to add, and adding commit to this ticket 





Edit: I forgot to mention why adding commit now, I think getting these 5.0-5.5 branches landed now will get these 6 branches tested on the build server, if the zips look good and no issues observed on the build server and build.trac.w.org then these packages can be tested to ensure site upgrades work as expected and then we can move forward for 3.7-4.9 branches and do the same, thus when it's time to perform a new release this will have been tested prior to landing any newer commits in these branches relating to any release




    

  

    Last edited 4 years ago
        by netweb
      (previous)
      (diff)
  


              

              
              

                
  

    
      
    #31
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

Thanks for taking a look @netweb!





I've fixed a few discrepancies in JS files I found in 4.2-4.4 branches (see #52367) today, as well as updating all branches with autoprefixer to include [50017] from trunk, and 5.5 to include [50016].





I have also reverted all browser specific CSS changes that happened as a result of running grunt browserify or grunt precommit:css. This decreased the number of files changed further (between 10-40 depending on the branch). Ensuring the correct browser prefixes are present (or not) is not a part of this effort, it just happened as a result of testing the various Grunt scripts.





Excluding these will also allow #52331 to progress separately. The companion WordPress/WordPress PRs have also been updated for comparison.





I opened a PR to test backporting the package updates to 5.6. Even though it already runs on NodeJS 14.x, we should also bring that branch up to date with trunk so that everything is in sync. Will probably commit that tomorrow, and probably start on the 5.x branches.




    


              

              

                
  

    
      
    #32
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50023:





Build/Test Tools: Update several dependencies in the 5.6 branch.





This backports several dependency updates to the 5.6 branch as a part of #52341 to allow all branches receiving security updates to run on NodeJS 14.x.





Backports [49933,49937,49939,49940,49983,49989,49990,50016,50017] to the 5.6 branch.

See #51801, #52341.





    


              

              

                
  

    
      
        
        

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.



      
      
4 years ago
    
    

    

  


              

              

                
  

    
      
    #34
  
    
        
          
             @peterwilsoncc
            
4 years ago
        
    

    

  

  

    

      

In 50173:





Build/Test Tools: Update built files committed to src following [50023].





See #51801, #52341.





    


              

              

                
  

    
      
    #35
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50187:





Build/Test Tools: Pin NodeJS 14.x in the .nvmrc file for the 5.6 branch.





See #52341.





    


              

              

                
  

    
      
    #36
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50188:





Build/Test Tools: Support NodeJS 14.x in the 5.5 branch.





This updates the 5.5 branch to support the latest LTS version of NodeJS (currently 14.x) in an effort to allow the same version of NodeJS to be used across all WordPress branches receiving security updates as a courtesy.





In addition to backporting the package updates that happened after branching 5.5, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [48705,49636,49933,49937,49939-49940,49983,49989-49990,50016-50017,50126,50176,50185] to the 5.5 branch.

See #52341.





    


              

              
              

                
  

    
      
    #38
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50189:





Build/Test Tools: Support NodeJS 14.x in the 5.4 branch.





This updates the 5.4 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





In addition to backporting the package updates that happened after branching 5.4, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [47867,48213,47872-47873,48705,49636,49933,49937,49939,49940,49983,49989,50017,50126,50176,50185] to the 5.4 branch.

See #52341.





    


              

              
              

                
  

    
      
    #40
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50190:





Build/Test Tools: Support NodeJS 14.x in the 5.3 branch.





This updates the 5.3 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





In addition to backporting the package updates that happened after branching 5.3, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [47404,47867,47872-47873,48213,48705,49636,49933,49937,49939,49940,49983,49989,50017,50126,50176,50185] to the 5.3 branch.

See #52341.





    


              

              

                
  

    
      
    #41
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50191:





Build/Test Tools: Support NodeJS 14.x in the 5.2 branch.





This updates the 5.2 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





In addition to backporting the package updates that happened after branching 5.2, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin, whyisjake.

Merges [45321,45765,45826,45875,46403-46404,46408-46409,47404,47867,47872-47873,48213,48705,49636,49933,49937,49939-49940,49983,49989,50017,50126,50176,50185] to the 5.2 branch.

See #52341.





    


              

              
              

                
  

    
      
    #43
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50192:





Build/Test Tools: Fix tests after [50185].





This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.





Props peterwilsoncc.

See #52341.





    


              

              

                
  

    
      
    #44
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50193:





Build/Test Tools: Fix tests after [50186].





This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.





Props peterwilsoncc.

Merges [50192] to the 5.6 branch.

See #52341.





    


              

              

                
  

    
      
    #45
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50194:





Build/Test Tools: Fix tests after [50188].





This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.





Props peterwilsoncc.

Merges [50192] to the 5.5 branch.

See #52341.





    


              

              

                
  

    
      
    #46
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50195:





Build/Test Tools: Fix tests after [50189].





This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.





Props peterwilsoncc.

Merges [50192] to the 5.4 branch.

See #52341.





    


              

              

                
  

    
      
    #47
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50196:





Build/Test Tools: Fix tests after [50190].





This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.





Props peterwilsoncc.

Merges [50192] to the 5.3 branch.

See #52341.





    


              

              

                
  

    
      
    #48
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50197:





Build/Test Tools: Fix tests after [50191].





This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.





Props peterwilsoncc.

Merges [50192] to the 5.2 branch.

See #52341.





    


              

              

                
  

    
      
    #49
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50199:





Build/Test Tools: Support NodeJS 14.x in the 5.1 branch.





This updates the 5.1 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





In addition to backporting the package updates that happened after branching 5.1, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [44233,44728,45321,45765,45826,46403-46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,49940,49983,49989,50017,50126,50176,50185] to the 5.1 branch.

See #52341.





    


              

              

                
  

    
      
    #50
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50200:





Build/Test Tools: Fix tests after [50199].





This removes a test assertion defending against version ranges in the node value in package.json files. This is now supported.





Props peterwilsoncc.

Merges [50192] to the 5.1 branch.

See #52341.





    


              

              
              

                
  

    
      
    #52
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50201:





Build/Test Tools: Support NodeJS 14.x in the 5.0 branch.





This updates the 5.0 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





In addition to backporting the package updates that happened after branching 5.0, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [44233,44728,45321,45765,45826,46403-46404,46408,46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,49940,49983,49989,50017,50126,50176,50185,50192] to the 5.0 branch.

See #52341.





    


              

              
              

                
  

    
      
    #54
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50202:





Build/Test Tools: Support NodeJS 14.x in the 4.9 branch.





This updates the 4.9 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





This also replaces the npm-shrinkwrap.json with a package-lock.json file. Lock files were not supported in earlier versions of NPM, but can now be used.





In addition to backporting the package updates that happened after branching 4.9, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.9 branch.

See #52341.





    


              

              
              

                
  

    
      
    #56
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50203:





Build/Test Tools: Support NodeJS 14.x in the 4.8 branch.





This updates the 4.8 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





This also replaces the npm-shrinkwrap.json with a package-lock.json file. Lock files were not supported in earlier versions of NPM, but can now be used.





In addition to backporting the package updates that happened after branching 4.8, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.8 branch.

See #52341.





    


              

              
              

                
  

    
      
    #58
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50204:





Build/Test Tools: Support NodeJS 14.x in the 4.7 branch.





This updates the 4.7 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





This also replaces the npm-shrinkwrap.json with a package-lock.json file. Lock files were not supported in earlier versions of NPM, but can now be used.





In addition to backporting the package updates that happened after branching 4.7, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.7 branch.

See #52341.





    


              

              
              

                
  

    
      
    #60
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50205:





Build/Test Tools: Ignore patch related files, so they can't be accidentally committed.





Merges [39360-39361] to the 4.7 branch.

See #52341.





    


              

              

                
  

    
      
    #61
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50206:





Build/Test Tools: Support NodeJS 14.x in the 4.6 branch.





This updates the 4.6 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





This also replaces the npm-shrinkwrap.json with a package-lock.json file. Lock files were not supported in earlier versions of NPM, but can now be used.





In addition to backporting the package updates that happened after branching 4.6, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185] to the 4.6 branch.

See #52341.





    


              

              
              

                
  

    
      
    #63
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50208:





Build/Test Tools: Support NodeJS 14.x in the 4.5 branch.

 

This updates the 4.5 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This also replaces the npm-shrinkwrap.json with a package-lock.json file. Lock files were not supported in earlier versions of NPM, but can now be used.





In addition to backporting the package updates that happened after branching 4.5, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [37185,37212,37612,38111,38688,39110,39113-39119,39478,42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.5 branch.

See #52341.





    


              

              
              

                
  

    
      
    #65
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50210:





Build/Test Tools: Support NodeJS 14.x in the 4.4 branch.

 

This updates the 4.4 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This also replaces the npm-shrinkwrap.json with a package-lock.json file. Lock files were not supported in earlier versions of NPM, but can now be used.





In addition to backporting the package updates that happened after branching 4.4, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [35859,35862,36860-36865,36935,36978-36979,37017,37019-37020,37212,37612,38111,38688,39110,39113-39119,39478,42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.4 branch.

See #52341.





    


              

              
              

                
  

    
      
    #67
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50212:





Build/Test Tools: Support NodeJS 14.x in the 4.3 branch.

 

This updates the 4.3 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This change also introduces a packager-lock.json file to the branch.





In addition to backporting the package updates that happened after branching 4.3, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [33726,34888,35332,35335,35363,35513,35520-35521,35538-35541,35562-35563,35859-36865,36935,36978-36980,37017,37019-37020,37212,37612,38111,38688,39110,39113-39119,39478,42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185] to the 4.3 branch.

See #52341.





    


              

              
              

                
  

    
      
    #69
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50214:





Build/Test Tools: Support NodeJS 14.x in the 4.2 branch.





This updates the 4.2 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This change also introduces a packager-lock.json file to the branch.





In addition to backporting the package updates that happened after branching 4.2, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [32356-32357,32988,33726,34888,35335,35363,35513,35521,35538-35541,35859,36861-36865,36935,36979,37017,37019-37020,37212,37612,38111,39110,39113,39115-39119,39478,41835,42460,42461,42463,42887,43320,43323,43977,44219,44233,45321,45765,46404,46408-46409,47404,47867,47872-47873,48705,49636,49933,49937,49939,50126,50176,50185] to the 4.2 branch.

See #52341.





    


              

              
              

                
  

    
      
    #71
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50216:





Build/Test Tools: Support NodeJS 14.x in the 4.1 branch.

 

This updates the 4.1 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This change also introduces a packager-lock.json file to the branch.





In addition to backporting the package updates that happened after branching 4.1, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [31425,31504,31557,31648-31650,32356-32357,32988,33726,35363,35513,35521,35538-35541,35859,36861-36865,37017,37019-37020,37212,37612,38111,39110,39113,39115-39117,39478,41835,42460-42461,42463,42887,43320,43323,43977,44219,44233,45321,45765,46404,46408-46409,47404,47867,47872-47873,48705,49636,49933,49937,49939,50126,50176,50185] to the 4.1 branch.

See #52341.





    


              

              
              

                
  

    
      
    #73
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50218:





Build/Test Tools: Support NodeJS 14.x in the 4.0 branch.

 

This updates the 4.0 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This change also introduces a packager-lock.json file to the branch.





In addition to backporting the package updates that happened after branching 4.0, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [30059-30063,30066-30067,31425,31504,31557,31648,31649-31650,32356-32357,32988,33726,35363,35513,35521,35538-35541,35859,36861-36865,37017,37019-37020,37212,37612,38111,39110,39113,39115-39117,39478,41835,42460-42461,42463,42887,43320,43323,43977,44219,44233,45321,45765,46404,46408-46409,47404,47867,47872-47873,48705,49636,49933,49937,49939,50126,50176,50185,50192] to the 4.0 branch.

See #52341.





    


              

              
              

                
  

    
      
    #75
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50220:





Build/Test Tools: Support NodeJS 14.x in the 3.9 branch.





This updates the 3.9 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This change also introduces a packager-lock.json file to the branch.





In addition to backporting the package updates that happened after branching 3.9, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [28695,28796,28821,29270,29505,29858-30059,30061-30063,30066-30067,31425,31504,31557,31648-31650,32356-32357,32988,33726,35363,35513,35521,35538-35541,35859,36861-36865,37017,37019,37020,37212,37612,38111,39110,39113,39115-39117,39478,41835,42460-42461,42463,42887,43320,43323,43977,44219,44233,45321,45765,46404,46408-46409,47404,47867,47872-47873,48705,49636,49933,49937,49939,50126,50176,50185] to the 3.9 branch.

See #52341.





    


              

              
              

                
  

    
      
    #77
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50222:





Build/Test Tools: Support NodeJS 14.x in the 3.8 branch.

 

This updates the 3.8 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This change also introduces a packager-lock.json file to the branch.





In addition to backporting the package updates that happened after branching 3.8, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [26886,27053,28796,27053,29270,29505,30060,30062-30063,30066,31425,31648,31649,31650,32356,32988,33726,35363,35513,35521,35538-35541,36861-36865,37017,37019,37020,37212,39110,39113,39115-39116,39117,39478,41835,42460,42461,42463,43320,43323,43977,44219,44233,45321,46408-46409,47404,47867,47872-47873,49636,49933,49937,49939,50126,50176,50185,50192] to the 3.8 branch.

See #52341.





    


              

              
              

                
  

    
      
    #79
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50224:





Build/Test Tools: Support NodeJS 14.x in the 3.7 branch.





This updates the 3.7 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.





Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).





This change also introduces a packager-lock.json file to the branch.





In addition to backporting the package updates that happened after branching 3.7, dependencies that were removed in future releases have also been updated to their latest versions.





Props desrosj, dd32, netweb, jorbin.

Merges [27053,27299,27721,27848,28796,29270,30060,30062-30063,30066,31557,31650,32356,32988,33726,35513,35521,35538,35540-35541,36861-36865,37019-37020,37212,37612,38111,39113,39115-39117,39478,42460-42461,42887,42989,43320,43323,43977,44219,45446,45765,46408-46409,47867,47872,48705,49636,49933,49939,50185] to the 3.7 branch.

See #52341.





    


              

              

                
  

    
      
    #80
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

  
    
    
  • 
      Keywords
        needs-testing commit removed
    
  • 
      Resolution
        set to fixed
    
  • 
      Status
        changed from assigned to closed
    
  • 
      Version
        set to 3.7
    
    • 
  

    

      

The 14.x version of NodeJS is now supported in all branches receiving courtesy updates.




    


              

              

                
  

    
      
    #81
  
    
        
          
             @SergeyBiryukov
            
4 years ago
        
    

    

  

  

    

      

In 50226:





Build/Test Tools: Correct svn:mergeinfo for the 4.3 branch.





Follow-up to [50212].





See #52341.





    


              

              

                
  

    
      
    #82
  
    
        
          
             @SergeyBiryukov
            
4 years ago
        
    

    

  

  

    

      

In 50227:





Build/Test Tools: Correct svn:mergeinfo for the 3.9 branch.





Follow-up to [50220].





See #52341.





    


              

              

                
  

    
      
        
        

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.



      
      
4 years ago
    
    

    

  


              

              

                
  

    
      
    #84
  
    
        
          
             @desrosj
            
4 years ago
        
    

    

  

  

    

      

In 50539:





Build/Test Tools: Pin NodeJS 14.x in the .nvmrc file for the 5.7 branch.





See #52341.





    


              

          

        

      
Note: See
        TracTickets for help on using
        tickets.