Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #52341, comment 20


Ignore:
Timestamp:
01/22/2021 12:36:42 AM (5 years ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #52341, comment 20

    v1 v2  
    11Few more notes:
    22- I also did not backport tools that were not present in the branch. For example, JS documentation linting added in 5.5 was not backported, coding standards tooling that was added in 5.1 was not backported, etc.
    3 - For the `.nvmrc` file, I currently have `14` as the value. `lts/*` was present in many newer branches, but the best approach for this is not clear to me. Using 14 would require a commit to each branch moving forward when new LTS versions are released. But it would also prevent branches from suddenly failing.
     3- For the `.nvmrc` file, I currently have `14` as the value. This would keep the user within the last tested LTS, while still running the latest release in that series. `lts/*` was present in many newer branches, but the best approach for this is not clear to me. Using 14 would require a commit to each branch moving forward when new LTS versions are released. But it would also prevent branches from suddenly failing.
    44- I updated the `engines` values in the `package.json` file to be ranges, using `>=`. With the deprecation of `engines-strict`, these values are merely suggestions, so this seems OK, but open to learning best practices here.