#52355 closed enhancement (fixed)
Twenty Twenty: remove aria-expanded on Close Search button
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | 5.6 |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | accessibility | Cc: |
Description (last modified by )
Theme: Twenty Twenty
When opening the search form in the header, the Search button automatically gets aria-expanded toggled. However, on the Close Search button, aria-expanded="false" is set by default. Need to remove this attribute as Close Search does not toggle any behavior, it is simply a regular button to close the search form.
Attachments (2)
Change History (11)
#1
@
4 years ago
- Description modified (diff)
- Owner set to alexstine
- Status changed from new to accepted
- Summary changed from Twenty Twenty-One: remove aria-expanded on Close Search button to Twenty Twenty: remove aria-expanded on Close Search button
This ticket was mentioned in PR #918 on WordPress/wordpress-develop by alexstine.
4 years ago
#2
- Keywords has-patch added
#3
@
4 years ago
- Keywords needs-testing added
- Milestone changed from Awaiting Review to 5.7
This is ready for testing.
To test:
- Activate Twenty Twenty theme.
- Apply this patch.
- Select Search.
- Select Close Search.
- Check HTML via inspector to make sure aria-expanded="true/false" does not exist on Close Search button.
Thanks.
This ticket was mentioned in Slack in #accessibility by alexstine. View the logs.
4 years ago
#5
@
4 years ago
- Keywords commit added; needs-testing removed
Hi @alexstine, I tested your patch. It works fine and sounds legit to me.
Above, I shared two animated screenshot to demonstrate that your patch fixes the issue.
Looks good to go on my side. Removing needs-testing
workflow keyword and replacing it with commit
:-)
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by monikarao. View the logs.
4 years ago
hellofromtonya commented on PR #918:
4 years ago
#9
Ticket closed with changeset https://core.trac.wordpress.org/changeset/50033
https://core.trac.wordpress.org/ticket/52355#comment:1