Context Navigation

← Previous Ticket
Next Ticket →

#52375 closed enhancement (fixed)

Extract the validation of specific data types from rest_validate_value_from_schema() into separate functions

Reported by:	yakimun	Owned by:	TimothyBlynJacobs
Priority:	normal	Milestone:	5.7
Component:	REST API	Version:	4.7
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

The current implementation of the rest_validate_value_from_schema function contains a lot of code and is difficult to read. Most of the code of this function is related to the validation of specific data types.

We can extract the type validation logic into separate functions to improve readability and maintainability.

Change History (4)

This ticket was mentioned in PR #924 on WordPress/wordpress-develop by yakimun.

5 years ago #1

Keywords has-patch added

Specific types validation logic extracted from the rest_validate_value_from_schema function into separate functions.

Trac ticket: https://core.trac.wordpress.org/ticket/52375

#2 @TimothyBlynJacobs
5 years ago

Milestone Awaiting Review → 5.7
Version → 4.7

Thanks for the patch, this is a great improvement @yakimun!

#3 @TimothyBlynJacobs
5 years ago

Owner set to TimothyBlynJacobs
Resolution → fixed
Status new → closed

In 50060:

REST API: Refactor rest_validate_value_from_schema into separate validation functions per-type.

Props yakimun.
Fixes #52375.

TimothyBJacobs commented on PR #924:

5 years ago #4

Merged in https://github.com/WordPress/wordpress-develop/commit/09a72ba49f5e8bdb396465a38a67d70f68553db3.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core