WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 4 months ago

#52380 closed defect (bug) (fixed)

Twenty Twenty-One: Word wrap missing in comments

Reported by: mayankmajeji Owned by: desrosj
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-screenshots has-patch
Focuses: css Cc:

Description

I was testing with unit test data and found out that word-wrap is missing in Twenty Twenty One's long comment

Attachments (6)

twenty-twenty-one-long-comment.JPG (34.5 KB) - added by mayankmajeji 5 months ago.
twenty-twenty-one-long-comment-word-wrap-missing
52380.diff (1.9 KB) - added by mayankmajeji 5 months ago.
#52380 Patch
52380.1.diff (859 bytes) - added by audrasjb 5 months ago.
Patch refresh
Capture d’écran 2021-01-26 à 21.10.53.png (75.3 KB) - added by audrasjb 5 months ago.
Before 52380.1.diff
Capture d’écran 2021-01-26 à 21.10.34.png (79.4 KB) - added by audrasjb 5 months ago.
After 52380.1.diff
52380.2.diff (1.2 KB) - added by audrasjb 5 months ago.
The previous patch omitted to take RTL styles into account

Download all attachments as: .zip

Change History (13)

@mayankmajeji
5 months ago

twenty-twenty-one-long-comment-word-wrap-missing

@mayankmajeji
5 months ago

#52380 Patch

#1 @audrasjb
5 months ago

  • Component changed from General to Bundled Theme
  • Milestone changed from Awaiting Review to 5.7

@audrasjb
5 months ago

Patch refresh

@audrasjb
5 months ago

Before 52380.1.diff

#2 @audrasjb
5 months ago

  • Version set to 5.6

Good catch @mayankmajeji.

I refreshed your patch because it needs to be generated against wordpress-develop /src folder, and it also contained some unwanted changes.

Thanks for raising this issue!

@audrasjb
5 months ago

The previous patch omitted to take RTL styles into account

#3 @mayankmajeji
5 months ago

@audrasjb Awesome! VSCode must have added the unwanted changes. I should remove the auto-format on save. Thanks for making the changes. :)

#4 @SergeyBiryukov
5 months ago

  • Summary changed from Word Wrap Missing to Twenty Twenty-One: Word wrap missing in comments

This ticket was mentioned in Slack in #core-themes by poena. View the logs.


4 months ago

#6 @desrosj
4 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

#7 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 50158:

Twenty Twenty-One: Fix wrapping for long text within comments.

This ensures that word wrapping occurs within comment content.

Props mayankmajeji, audrasjb.
Fixes #52380.

Note: See TracTickets for help on using tickets.