Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#52385 closed enhancement (fixed)

Remove Editor Dark Mode

Reported by: scruffian Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description (last modified by sabernhardt)

When Gutenberg PR 28233 merges, we'll need to remove these lines from core, since they won't serve any purpose.

Attachments (1)

dark-mode.patch (608 bytes) - added by scruffian 9 months ago.

Download all attachments as: .zip

Change History (7)

#1 @sabernhardt
9 months ago

  • Component changed from General to Editor
  • Description modified (diff)
  • Keywords has-patch added

#2 @SergeyBiryukov
9 months ago

Looks like the PR is now merged in Gutenberg 9.9.

Is there a way to know whether Gutenberg 9.9 will be included in WordPress 5.7 or not?

#3 @sabernhardt
9 months ago

@nosolosw just mentioned 9.9 would be included, in #core-editor

#4 @SergeyBiryukov
9 months ago

  • Milestone changed from Awaiting Review to 5.7

#5 @SergeyBiryukov
9 months ago

  • Keywords commit added

#6 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 50142:

Block Editor: Remove the .is-dark-theme body class from the admin header.

With the changes to dark theme support in https://github.com/WordPress/gutenberg/pull/28233 to check the real background color of the theme, this no longer serves any purpose.

Follow-up to [44133].

Props scruffian, sabernhardt.
Fixes #52385.

Note: See TracTickets for help on using tickets.