Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#52401 closed defect (bug) (fixed)

Twenty Twenty: RTL list styles

Reported by: desrosj's profile desrosj Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

In #51574/[49510], styles were added to ensure proper nesting of nested unordered lists in the RTL style sheet.

This fixes the issue, but because the RTL stylesheets are built, the added style is removed after running npm run build.

To preserve the styles in the RTL stylesheet going forward, a reflective style needs to be added to the LTR stylesheet.

Attachments (4)

52401.diff (681 bytes) - added by desrosj 3 years ago.
Twenty Twenty.png (342.3 KB) - added by mukesh27 3 years ago.
52401-before.png (70.7 KB) - added by sabernhardt 3 years ago.
before patch in English, 5.7 trunk, Firefox/Windows
52401-after.png (70.9 KB) - added by sabernhardt 3 years ago.
after patch in English, 5.7 trunk, Firefox/Windows

Download all attachments as: .zip

Change History (10)

@desrosj
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.7

#2 @mukesh27
3 years ago

Hi!

There is no left padding in the frontend so do we need to add left padding in the frontend?

#3 @sabernhardt
3 years ago

52401.diff is fine, though the value could be adjusted from 2em to 1.3em for better consistency. The patch would keep those indentations for any sites using the next version of Twenty Twenty with either WordPress 5.5 or 5.6.

Reverting [49510] is another option. GB27947 fixed the underlying problem behind #51574 on the editor side for WordPress 5.7 (merged into trunk with #52394).

The left margin and padding added to these list elements was not reflected in RTL, and [49510] worked around that in the Twenty Twenty theme instead of correcting in the editor.

.editor-styles-wrapper ul,
.editor-styles-wrapper ol {
    margin-bottom: 28px;
    padding-left: 1.3em;
    margin-left: 1.3em;
}

Twenty Nineteen never had a theme-specific patch, so I'll close #51573.

@sabernhardt
3 years ago

before patch in English, 5.7 trunk, Firefox/Windows

@sabernhardt
3 years ago

after patch in English, 5.7 trunk, Firefox/Windows

#4 @ryelle
3 years ago

  • Keywords commit added

I think it makes sense to commit this patch so that the two files are synced up correctly, and so that Twenty Twenty can still support older WP versions.

#5 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#6 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 50359:

Twenty Twenty: Make sure the RTL list styles are preserved after npm run build.

Adjust the padding value for better consistency.

Props desrosj, sabernhardt, ryelle, mukesh27.
Fixes #52401.

Note: See TracTickets for help on using tickets.