WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#52430 closed task (blessed) (fixed)

Privacy code adjustments after 5.7 beta 1

Reported by: xkon Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description

Some small adjustments while re-checking/testing the 5.7 beta 1 changes.

  • Some links of the introduced Help tabs are pointing to privacy-policy-guide.php they should be adjusted to options-privacy.php?tab=policyguide for the new privacy settings design. Follow up for #43994.
  • A gray left border appears in the inline-notices on policy guide (similar to suggested text border), that needs to be removed. Follow up for #49264.
  • Adjusting the new parameter added in wp_create_user_request for clarity according to coding standards and easier/correct usage. Follow up for #43890. Thanks to @TimothyBlynJacobs for brainstorming on this.

I'm adding a PR providing these changes, I thought of combining everything since they are small updates (at least the 2 first mentioned) and not breaking any functionality.

Feel free to tell me and I can easily split them up into individual PRs/patches in case we want to reopen the mentioned tickets :) .

Change History (15)

This ticket was mentioned in PR #974 on WordPress/wordpress-develop by mrxkon.


6 months ago

d8af5c1 fixes a gray border in inline admin notices.

1fabee1 fixes the links introduced in new Help tabs to point to the correct policy guide page of the new design.

f37ee4b changes $send_confirmation_email to $status in wp_create_user_request for code clarity, also adjusts unittests.

As mentioned in the Trac ticket, do tell me if I should split these up instead :).

Trac ticket: https://core.trac.wordpress.org/ticket/52430

#2 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @kebbet
6 months ago

  • Keywords needs-refresh added

The color for the border should be picked from the new CSS-colors by @ryelle not border-left: 1px solid grey;

#4 @xkon
6 months ago

@kebbet sure I can update the grey. Do you have a value to recommend or a related ticket that has the updates for admin colors in general I'll see what we can use. Not sure if we have them documented somewhere.

#5 @kebbet
6 months ago

@xkon thanks!

The ticket is: #49999 and the color scheme is https://codepen.io/ryelle/full/WNGVEjw

Grey50 looks ok to me – #646970

Last edited 6 months ago by SergeyBiryukov (previous) (diff)

#6 @kebbet
6 months ago

And arrows (.privacy-settings-accordion-trigger .icon, .privacy-settings-view-read .icon) should probably have Grey40 #787c82 which are used on the dashboard. The color used now is not in the new color scheme.

#7 @xkon
6 months ago

  • Keywords commit added; needs-refresh removed

Great thanks for the information!

Since I see that Site Health was updated as well (I totally missed that) I'll cross check what was changed there since it's the same UI and use those values according to the scheme also as I see we'll need various changes :D. This is exactly why I opened #52429 as well so we can keep both UIs in sync more easily.

As I don't want this PR to get over-worked (it has 3 different tickets attached already), I'll split the CSS updates to a new ticket and I'll handle everything there so they can also be easily reviewing without irrelevant code attached.

I'm marking this back to has-patch & commit for @SergeyBiryukov to have an easier review and will update here with a further comment for the new split ticket.

#8 @kebbet
6 months ago

You are welcome, sounds like a good idea! (When I started digging into [50161] I found even more mismatches.)

Last edited 6 months ago by SergeyBiryukov (previous) (diff)

#9 @xkon
6 months ago

CSS color updates will be handled at #52436 :) .

This ticket was mentioned in Slack in #core-privacy by hellofromtonya. View the logs.


6 months ago

#11 @hellofromTonya
6 months ago

  • Type changed from enhancement to task (blessed)

Reclassifying to task for the refinement past Beta 1.

#12 @SergeyBiryukov
6 months ago

In 50181:

Privacy: Update URLs to the Privacy Policy Guide in help tabs.

Follow-up to [50147], [50161].

Props xkon.
See #52430.

#13 @SergeyBiryukov
6 months ago

In 50182:

Privacy: Remove gray left border on the inline notices in Privacy Policy Guide.

Follow-up to [50161].

Props xkon.
See #52430.

#14 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 50230:

Privacy: Rename the $send_confirmation_email parameter of wp_create_user_request() to $status, for clarity.

Follow-up to [50159], [50165].

Props xkon, TimothyBlynJacobs.
Fixes #52430. See #43890.

Note: See TracTickets for help on using tickets.