Opened 6 years ago
Closed 5 years ago
#52436 closed task (blessed) (fixed)
Update privacy settings color scheme
| Reported by: | xkon | Owned by: | ryelle |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.7 |
| Component: | Privacy | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | ui, css, administration |
Description
Thanks to @kebbet for pointing this out & splitting from #52430 .
The privacy settings new design has an outdated CSS scheme as it seems (whoopsie!).
We'll have to update the colors to match the new scheme according to #49999 & https://codepen.io/ryelle/full/WNGVEjw .
It would be good to also check the differences in site-health.css which seems to be updated to keep both UIs aligned in regards to coloring.
Attachments (3)
Change History (9)
#1
follow-up:
↓ 2
@
6 years ago
I added 52436.diff to update the colors - it doesn't change any UI styling.
One thing I noticed in passing is that there are .badge styles in the privacy CSS, but I don't see badges on the page (in Site Health, that's the "Security", "Performance" labels).
#2
in reply to: ↑ 1
@
6 years ago
Replying to ryelle:
One thing I noticed in passing is that there are
.badgestyles in the privacy CSS, but I don't see badges on the page (in Site Health, that's the "Security", "Performance" labels).
The badges on the page show up if you deactivate a plugin that had a policy, or if the plugin's policy updates.
This ticket was mentioned in Slack in #core-privacy by hellofromtonya. View the logs.
6 years ago
#4
@
6 years ago
- Type enhancement → task (blessed)
Reclassifying to task for the refinement past Beta 1.
#5
@
6 years ago
- Keywords has-patch commit added; needs-patch removed
Thanks a lot @ryelle ! As @TimothyBlynJacobs the badges are shown under specific occasions, attaching badges.jpg for a small preview if needed.
52436.2.diff is a refresh to apply cleanly after 50182.
Marking this for commit, thanks again!
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Update colors