WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#52436 closed task (blessed) (fixed)

Update privacy settings color scheme

Reported by: xkon Owned by: ryelle
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: has-patch commit
Focuses: ui, css, administration Cc:

Description

Thanks to @kebbet for pointing this out & splitting from #52430 .

The privacy settings new design has an outdated CSS scheme as it seems (whoopsie!).

We'll have to update the colors to match the new scheme according to #49999 & https://codepen.io/ryelle/full/WNGVEjw .

It would be good to also check the differences in site-health.css which seems to be updated to keep both UIs aligned in regards to coloring.

Attachments (3)

52436.diff (3.4 KB) - added by ryelle 8 months ago.
Update colors
52436.2.diff (3.4 KB) - added by xkon 8 months ago.
badges.jpg (42.1 KB) - added by xkon 8 months ago.

Download all attachments as: .zip

Change History (9)

@ryelle
8 months ago

Update colors

#1 follow-up: @ryelle
8 months ago

I added 52436.diff to update the colors - it doesn't change any UI styling.

Version 0, edited 8 months ago by ryelle (next)

#2 in reply to: ↑ 1 @TimothyBlynJacobs
8 months ago

Replying to ryelle:

One thing I noticed in passing is that there are .badge styles in the privacy CSS, but I don't see badges on the page (in Site Health, that's the "Security", "Performance" labels).

The badges on the page show up if you deactivate a plugin that had a policy, or if the plugin's policy updates.

This ticket was mentioned in Slack in #core-privacy by hellofromtonya. View the logs.


8 months ago

#4 @hellofromTonya
8 months ago

  • Type changed from enhancement to task (blessed)

Reclassifying to task for the refinement past Beta 1.

@xkon
8 months ago

@xkon
8 months ago

#5 @xkon
8 months ago

  • Keywords has-patch commit added; needs-patch removed

Thanks a lot @ryelle ! As @TimothyBlynJacobs the badges are shown under specific occasions, attaching badges.jpg for a small preview if needed.

52436.2.diff is a refresh to apply cleanly after 50182.

Marking this for commit, thanks again!

#6 @ryelle
8 months ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 50238:

Privacy: Update colors to match new color palette.

Follow-up to [50161].
Props xkon.
Fixes #52436.

Note: See TracTickets for help on using tickets.