Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 17 years ago

#5246 closed defect (bug) (fixed)

size_format doesn't work for TB

Reported by: nbachiyski Owned by:
Priority: normal Milestone: 2.5
Component: General Version:
Severity: normal Keywords: size_format has-patch
Cc: Focuses:

Description

size_format runs the number through int_val, which casts it to int, which is usually only 32 bits. Not enough for terabytes.

Attachments (2)

size_format.diff​ (1.5 KB ) - added by nbachiyski 19 years ago.
size_format_double-r6350.patch​ (457 bytes ) - added by tellyworth 19 years ago.
simpler patch with doubleval()

Download all attachments as: .zip

Change History (5)

@tellyworth
19 years ago

simpler patch with doubleval()

#1 @tellyworth
19 years ago

Simpler patch included - this one just uses doubleval() in place of intval().

Both pass unit tests incidentally - see test_size_format() in ​http://svn.automattic.com/wordpress-tests/wp-testcase/test_includes_functions.php.

#2 @darkdragon
19 years ago

Can this go in?

#3 @ryan
19 years ago

  • Resolution → fixed
  • Status new → closed

(In [6669]) doubleval bytes. Props tellyworth. fixes #5246

Note: See TracTickets for help on using tickets.