The value of argument passed to the update_option_new_admin_email() is not a valid email.

[tremidkhar]

While creating a patch for ticket #43706, I found out that the function update_option_new_admin_email() is responsible for the template. It does accept two parameters, however, the first parameter $old_value does not seem to get the correct value.

When checking the value, it holds the value new_admin_email instead of the old email address.

Thanks!

When changing the admin email address, the argument passed to update_option_new_admin_email() function is a string instead of an email address.

Trac ticket: https://core.trac.wordpress.org/ticket/52464

[chaion07]

Thanks to @tremidkhar for reporting this. We reviewed this ticket during a recent [bug-scrub session]​https://wordpress.slack.com/archives/C02RQBWTW/p1623098372373600. With Beta 1 coming in a day, checking with @SergeyBiryukov to kindly draw some attention to this. Thank you!

[hellofromTonya]

Today is 5.8 Beta 1. With no activity, punting to 5.9.

[hellofromTonya]

Hello @tremidkhar,

Welcome to WordPress Core Trac!

First of all, I'm sorry your ticket and patch has not yet been reviewed, but rather punted from release to release.

Can you please provide step-by-step instructions on how to reproduce the reported problem? First step will be to reproduce it and then dive in to investigate why it's happening. Marking the ticket for needs-testing-info.

Also, if a new function is what's needed, it will require unit tests. Marking the ticket to note that need.

With 5.9 Beta 1 in 2 days and no activity (yet) on this ticket, moving it to 6.0. However, if the problem is reproducible and the patch is ready, then it can be moved back into the 5.9 milestone for commit consideration. Else, let's see if it can be resolved in 6.0.

[hellofromTonya]

As 6.0 RC1 is tomorrow and there's been no activity since it was punted from 5.9, moving this back to Awaiting Review.

[tremidkhar]

Hello @hellofromTonya,

I apologize for the delay, Here is a video on how to reproduce the issue that I have mentioned.

​https://youtu.be/tvKBLnx6VfI

Trac ticket: https://core.trac.wordpress.org/ticket/52464

Closing this as the dev branch is out of date.

Opening a new PR ​here.

[tremidkhar]

Hello @SergeyBiryukov,

I have updated the ​PR for this. Can you have a look at it, please? Thank you.

Change the parameter $old_value to $deprecated, because it is not used in the function

Trac ticket: https://core.trac.wordpress.org/ticket/52464

[Soean]

@heikomamerow and I created a new PR. The first parameter of update_option_new_admin_email() is not used in the function, so we should deprecate it.