Missing dot in query.php, category exclusion problem

[jaroche]

I found that there's a missing dot when assigns the value to $whichcat in query.php, this interferes with the categories exclusion (generated with $q['category__not_in'] ).

[westi]

Patch against trunk

[westi]

I've updated the patch to catch another case of the same issue.

Needs testing though

Pushing to 2.4 as 2.3.1 is nearly out the door.

[ryan]

Concatenation is purposefully left off in some place to avoid creating invalid queries. category_name and categorynot_in might work together but category_name and others will not.

[westi]

Has this been fixed by [6345] as that issue may have caused problems with these query vars?

[Denis-de-Bernardy]

The lack of dot seems valid. Please re-open with a step by step test case to reproduce if it's still occurring.

[jaroche]

Patch against /trunk

[jaroche]

Hello,

I've updated the westi's patch for trunk. This fixes de bug for 2.9.2 and trunk.

To reproduce this bug:

1. Create a single plugin that adds:

   $query->set('cat','-$categoryidtoexclude');
   

2. Visit the category 'A' page (/category/a/) with posts categorized 'B', where category 'B' has been excluded.

[dd32]

You can also duplicate this with a url such as:

http://localhost/wordpress-commit/category/some-category/?cat=-1

Any posts in both will show, whereas you'd expect it to skip some.

However, I'm still going to push this out of 3.0 due to impending beta. I believe there are some other taxonomy query tickets which would be ideal to patch at the same time.

[wonderboymusic]

This code has been wiped out by time, no longer exists

[SergeyBiryukov]

Removed in [15613].