Site Health breaks when heartbeat deregistered

[gmariani405]

Site Health fails to complete if a plugin de-registers the heartbeat script which Site Health relies on to include wp-hooks. This occurs if you use a plugin to manage when heartbeat runs and how often.

I'd suggest listing wp-hooks as a dependency for Site Health instead of relying on heartbeat to include it.

This is the error generated on the Site Health page when heartbeat is de-registered:

11:36:24.820 TypeError: wp.hooks is undefined site-health.min.js:2:3983
    t https://example.com/wp-admin/js/site-health.min.js:2
    jQuery 4

[gmariani405]

Screenshot of error on Site Health page

Trac ticket: https://core.trac.wordpress.org/ticket/52483

[Clorith]

Good catch! Yes Site Health should be declaring that dependency explicitly as you mentioned. See ​PR 989 which adds the dependency.

Milestoning this for 5.7, as it's a bug with a clear solution, and the solution provides no side-effects.

[peterwilsoncc]

@Clorith wp-i18n is also missing as a direct dependency of the site-health JavaScript. It would be dandy to include that while making the change.

I did a quick search through the file for window. and wp. and I think once i18n is included everything will be good to go.

[mukesh27]

Updated patch.

[mukesh27]

52483.diff​ updated patch.

[Clorith]

Ahh, good catch, I was incidentally running the plugin version, which doesn't ahve the same dependencies (working on fixing that :) )

52483.diff​ looks good to go then.

[peterwilsoncc]

In 50294:

Site Health: Update site-health script dependencies.

Add wp-hooks and wp-i18n to Site Health JavaScript dependencies.

Props gmariani405, Clorith, mukesh27.
Fixes #52483.

Fixed in trunk.