WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

Last modified 5 months ago

#52521 closed enhancement (fixed)

Site Health: If there is only one recommendation, use singular

Reported by: Presskopp Owned by: SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch
Focuses: ui-copy Cc:

Description

Having 0 critical issues but 1 recommendation you can read on the dashboard:

Your site’s health is looking good, but there are still some things you can do to improve its performance and security.

We should rather say:

Your site’s health is looking good, but there is still a thing you can do to improve its performance and security.

Attachments (3)

52521.diff (883 bytes) - added by Presskopp 7 months ago.
52521.2.diff (887 bytes) - added by Presskopp 7 months ago.
52521.3.diff (1.3 KB) - added by Presskopp 6 months ago.

Download all attachments as: .zip

Change History (9)

@Presskopp
7 months ago

#1 @Presskopp
7 months ago

  • Keywords has-patch added

@Presskopp
7 months ago

This ticket was mentioned in Slack in #core-site-health by presskopp. View the logs.


6 months ago

#3 @Hareesh Pillai
6 months ago

  • Focuses ui-copy added

While we are at it, it is meaningful if we also address the case where there is just one critical issue.

Presently it is:

Your site has critical issues that should be addressed as soon as possible to improve its performance and security.

Instead it should be

Your site has a critical issue that should be addressed as soon as possible to improve its performance and security.

#4 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 5.8

@Presskopp
6 months ago

#5 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 50530:

Site Health: Use a singular string in dashboard widget if there is only one critical issue or recommendation.

Props Presskopp, hareesh-pillai.
Fixes #52521.

This ticket was mentioned in Slack in #core-test by boniu91. View the logs.


5 months ago

Note: See TracTickets for help on using tickets.