#52524 closed defect (bug) (fixed)
Add extra context to the `xmlrpc_call` action
Reported by: | dd32 | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | XML-RPC | Keywords: | has-patch |
Focuses: | Cc: |
Description
The xmlrpc_call
action currently passes the method name to the action, but fails to pass the arguments presented. That can make the action hard to use when the call passes specific content in the payload of the request.
For example, when the wp.getRevisions
XML-RPC call is made, it's impossible to tell what post is being accessed via the API for dynamic filtering without reaching into the internals of the global $wp_xmlrpc_server
object.
The attached PR simply adds the $args
parameter to the action call along with the RPC server for consistency sake.
Change History (8)
This ticket was mentioned in PR #1004 on WordPress/wordpress-develop by dd32.
4 years ago
#1
- Keywords has-patch added
#2
@
4 years ago
- Milestone changed from Awaiting Review to 5.7
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
johnbillion commented on PR #1004:
4 years ago
#4
This ticket was mentioned in PR #1073 on WordPress/wordpress-develop by dd32.
4 years ago
#5
Trac ticket: https://core.trac.wordpress.org/ticket/52524
#6
@
4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Re-opening for PR 1073 above, my PR incorrectly used $args
for two methods which have no args. This patch simply replaces it with an empty array.
Fixes the following PHP Notices:
E_NOTICE: Undefined variable: args in wp-includes/class-wp-xmlrpc-server.php:6652 E_NOTICE: Undefined variable: args in wp-includes/class-wp-xmlrpc-server.php:6664
Trac ticket: https://core.trac.wordpress.org/ticket/52524